Skip to content

Commit b2c1e4b

Browse files
committed
Improved XML doc for serializable networkedvar classes
1 parent 64f6ca0 commit b2c1e4b

File tree

2 files changed

+144
-2
lines changed

2 files changed

+144
-2
lines changed

MLAPI/Data/NetworkConfig.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,14 @@ public class NetworkConfig
149149
/// Wheter or not to enable signed diffie hellman key exchange.
150150
/// </summary>
151151
public bool SignKeyExchange = false;
152+
/// <summary>
153+
/// Pfx file in base64 encoding containing private and public key
154+
/// </summary>
152155
[TextArea]
153156
public string ServerBase64PfxCertificate;
157+
/// <summary>
158+
/// Gets the currently in use certificate
159+
/// </summary>
154160
public X509Certificate2 ServerX509Certificate
155161
{
156162
get
@@ -164,6 +170,9 @@ internal set
164170
}
165171
}
166172
private X509Certificate2 serverX509Certificate;
173+
/// <summary>
174+
/// Gets the cached binary representation of the server certificate that's used for handshaking
175+
/// </summary>
167176
public byte[] ServerX509CertificateBytes
168177
{
169178
get

MLAPI/Data/NetworkedVar.cs

Lines changed: 135 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ public bool CanClientWrite(uint clientId)
166166
/// Reads value from the reader and applies it
167167
/// </summary>
168168
/// <param name="stream">The stream to read the value from</param>
169+
/// <param name="keepDirtyDelta">Whether or not the container should keep the dirty delta, or mark the delta as consumed</param>
169170
public void ReadDelta(Stream stream, bool keepDirtyDelta)
170171
{
171172
using (PooledBitReader reader = PooledBitReader.Get(stream))
@@ -208,175 +209,307 @@ public string GetChannel()
208209
}
209210
}
210211

211-
// These support serialization
212+
/// <summary>
213+
/// A NetworkedVar that holds strings and support serialization
214+
/// </summary>
212215
[Serializable]
213216
public class NetworkedVarString : NetworkedVar<string>
214217
{
218+
/// <inheritdoc />
215219
public NetworkedVarString() { }
220+
/// <inheritdoc />
216221
public NetworkedVarString(NetworkedVarSettings settings) : base(settings) { }
222+
/// <inheritdoc />
217223
public NetworkedVarString(string value) : base(value) { }
224+
/// <inheritdoc />
218225
public NetworkedVarString(NetworkedVarSettings settings, string value) : base(settings, value) { }
219226
}
220227

228+
/// <summary>
229+
/// A NetworkedVar that holds bools and support serialization
230+
/// </summary>
221231
[Serializable]
222232
public class NetworkedVarBool : NetworkedVar<bool>
223233
{
234+
/// <inheritdoc />
224235
public NetworkedVarBool() { }
236+
/// <inheritdoc />
225237
public NetworkedVarBool(NetworkedVarSettings settings) : base(settings) { }
238+
/// <inheritdoc />
226239
public NetworkedVarBool(bool value) : base(value) { }
240+
/// <inheritdoc />
227241
public NetworkedVarBool(NetworkedVarSettings settings, bool value) : base(settings, value) { }
228242
}
229243

244+
/// <summary>
245+
/// A NetworkedVar that holds bytes and support serialization
246+
/// </summary>
230247
[Serializable]
231248
public class NetworkedVarByte : NetworkedVar<byte>
232249
{
250+
/// <inheritdoc />
233251
public NetworkedVarByte() { }
252+
/// <inheritdoc />
234253
public NetworkedVarByte(NetworkedVarSettings settings) : base(settings) { }
254+
/// <inheritdoc />
235255
public NetworkedVarByte(byte value) : base(value) { }
256+
/// <inheritdoc />
236257
public NetworkedVarByte(NetworkedVarSettings settings, byte value) : base(settings, value) { }
237258
}
238259

260+
/// <summary>
261+
/// A NetworkedVar that holds sbytes and support serialization
262+
/// </summary>
239263
[Serializable]
240264
public class NetworkedVarSByte : NetworkedVar<sbyte>
241265
{
266+
/// <inheritdoc />
242267
public NetworkedVarSByte() { }
268+
/// <inheritdoc />
243269
public NetworkedVarSByte(NetworkedVarSettings settings) : base(settings) { }
270+
/// <inheritdoc />
244271
public NetworkedVarSByte(sbyte value) : base(value) { }
272+
/// <inheritdoc />
245273
public NetworkedVarSByte(NetworkedVarSettings settings, sbyte value) : base(settings, value) { }
246274
}
247-
275+
276+
/// <summary>
277+
/// A NetworkedVar that holds ushorts and support serialization
278+
/// </summary>
248279
[Serializable]
249280
public class NetworkedVarUShort : NetworkedVar<ushort>
250281
{
282+
/// <inheritdoc />
251283
public NetworkedVarUShort() { }
284+
/// <inheritdoc />
252285
public NetworkedVarUShort(NetworkedVarSettings settings) : base(settings) { }
286+
/// <inheritdoc />
253287
public NetworkedVarUShort(ushort value) : base(value) { }
288+
/// <inheritdoc />
254289
public NetworkedVarUShort(NetworkedVarSettings settings, ushort value) : base(settings, value) { }
255290
}
256291

292+
/// <summary>
293+
/// A NetworkedVar that holds shorts and support serialization
294+
/// </summary>
257295
[Serializable]
258296
public class NetworkedVarShort : NetworkedVar<short>
259297
{
298+
/// <inheritdoc />
260299
public NetworkedVarShort() { }
300+
/// <inheritdoc />
261301
public NetworkedVarShort(NetworkedVarSettings settings) : base(settings) { }
302+
/// <inheritdoc />
262303
public NetworkedVarShort(short value) : base(value) { }
304+
/// <inheritdoc />
263305
public NetworkedVarShort(NetworkedVarSettings settings, short value) : base(settings, value) { }
264306
}
265307

308+
/// <summary>
309+
/// A NetworkedVar that holds uints and support serialization
310+
/// </summary>
266311
[Serializable]
267312
public class NetworkedVarUInt : NetworkedVar<uint>
268313
{
314+
/// <inheritdoc />
269315
public NetworkedVarUInt() { }
316+
/// <inheritdoc />
270317
public NetworkedVarUInt(NetworkedVarSettings settings) : base(settings) { }
318+
/// <inheritdoc />
271319
public NetworkedVarUInt(uint value) : base(value) { }
320+
/// <inheritdoc />
272321
public NetworkedVarUInt(NetworkedVarSettings settings, uint value) : base(settings, value) { }
273322
}
274323

324+
/// <summary>
325+
/// A NetworkedVar that holds ints and support serialization
326+
/// </summary>
275327
[Serializable]
276328
public class NetworkedVarInt : NetworkedVar<int>
277329
{
330+
/// <inheritdoc />
278331
public NetworkedVarInt() { }
332+
/// <inheritdoc />
279333
public NetworkedVarInt(NetworkedVarSettings settings) : base(settings) { }
334+
/// <inheritdoc />
280335
public NetworkedVarInt(int value) : base(value) { }
336+
/// <inheritdoc />
281337
public NetworkedVarInt(NetworkedVarSettings settings, int value) : base(settings, value) { }
282338
}
283339

340+
/// <summary>
341+
/// A NetworkedVar that holds ulongs and support serialization
342+
/// </summary>
284343
[Serializable]
285344
public class NetworkedVarULong : NetworkedVar<ulong>
286345
{
346+
/// <inheritdoc />
287347
public NetworkedVarULong() { }
348+
/// <inheritdoc />
288349
public NetworkedVarULong(NetworkedVarSettings settings) : base(settings) { }
350+
/// <inheritdoc />
289351
public NetworkedVarULong(ulong value) : base(value) { }
352+
/// <inheritdoc />
290353
public NetworkedVarULong(NetworkedVarSettings settings, ulong value) : base(settings, value) { }
291354
}
292355

356+
/// <summary>
357+
/// A NetworkedVar that holds longs and support serialization
358+
/// </summary>
293359
[Serializable]
294360
public class NetworkedVarLong : NetworkedVar<long>
295361
{
362+
/// <inheritdoc />
296363
public NetworkedVarLong() { }
364+
/// <inheritdoc />
297365
public NetworkedVarLong(NetworkedVarSettings settings) : base(settings) { }
366+
/// <inheritdoc />
298367
public NetworkedVarLong(long value) : base(value) { }
368+
/// <inheritdoc />
299369
public NetworkedVarLong(NetworkedVarSettings settings, long value) : base(settings, value) { }
300370
}
301371

372+
/// <summary>
373+
/// A NetworkedVar that holds floats and support serialization
374+
/// </summary>
302375
[Serializable]
303376
public class NetworkedVarFloat : NetworkedVar<float>
304377
{
378+
/// <inheritdoc />
305379
public NetworkedVarFloat() { }
380+
/// <inheritdoc />
306381
public NetworkedVarFloat(NetworkedVarSettings settings) : base(settings) { }
382+
/// <inheritdoc />
307383
public NetworkedVarFloat(float value) : base(value) { }
384+
/// <inheritdoc />
308385
public NetworkedVarFloat(NetworkedVarSettings settings, float value) : base(settings, value) { }
309386
}
310387

388+
/// <summary>
389+
/// A NetworkedVar that holds doubles and support serialization
390+
/// </summary>
311391
[Serializable]
312392
public class NetworkedVarDouble : NetworkedVar<double>
313393
{
394+
/// <inheritdoc />
314395
public NetworkedVarDouble() { }
396+
/// <inheritdoc />
315397
public NetworkedVarDouble(NetworkedVarSettings settings) : base(settings) { }
398+
/// <inheritdoc />
316399
public NetworkedVarDouble(double value) : base(value) { }
400+
/// <inheritdoc />
317401
public NetworkedVarDouble(NetworkedVarSettings settings, double value) : base(settings, value) { }
318402
}
319403

404+
/// <summary>
405+
/// A NetworkedVar that holds vector2s and support serialization
406+
/// </summary>
320407
[Serializable]
321408
public class NetworkedVarVector2 : NetworkedVar<Vector2>
322409
{
410+
/// <inheritdoc />
323411
public NetworkedVarVector2() { }
412+
/// <inheritdoc />
324413
public NetworkedVarVector2(NetworkedVarSettings settings) : base(settings) { }
414+
/// <inheritdoc />
325415
public NetworkedVarVector2(Vector2 value) : base(value) { }
416+
/// <inheritdoc />
326417
public NetworkedVarVector2(NetworkedVarSettings settings, Vector2 value) : base(settings, value) { }
327418
}
328419

420+
/// <summary>
421+
/// A NetworkedVar that holds vector3s and support serialization
422+
/// </summary>
329423
[Serializable]
330424
public class NetworkedVarVector3 : NetworkedVar<Vector3>
331425
{
426+
/// <inheritdoc />
332427
public NetworkedVarVector3() { }
428+
/// <inheritdoc />
333429
public NetworkedVarVector3(NetworkedVarSettings settings) : base(settings) { }
430+
/// <inheritdoc />
334431
public NetworkedVarVector3(Vector3 value) : base(value) { }
432+
/// <inheritdoc />
335433
public NetworkedVarVector3(NetworkedVarSettings settings, Vector3 value) : base(settings, value) { }
336434
}
337435

436+
/// <summary>
437+
/// A NetworkedVar that holds vector4s and support serialization
438+
/// </summary>
338439
[Serializable]
339440
public class NetworkedVarVector4 : NetworkedVar<Vector4>
340441
{
442+
/// <inheritdoc />
341443
public NetworkedVarVector4() { }
444+
/// <inheritdoc />
342445
public NetworkedVarVector4(NetworkedVarSettings settings) : base(settings) { }
446+
/// <inheritdoc />
343447
public NetworkedVarVector4(Vector4 value) : base(value) { }
448+
/// <inheritdoc />
344449
public NetworkedVarVector4(NetworkedVarSettings settings, Vector4 value) : base(settings, value) { }
345450
}
346451

452+
/// <summary>
453+
/// A NetworkedVar that holds colors and support serialization
454+
/// </summary>
347455
[Serializable]
348456
public class NetworkedVarColor : NetworkedVar<Color>
349457
{
458+
/// <inheritdoc />
350459
public NetworkedVarColor() { }
460+
/// <inheritdoc />
351461
public NetworkedVarColor(NetworkedVarSettings settings) : base(settings) { }
462+
/// <inheritdoc />
352463
public NetworkedVarColor(Color value) : base(value) { }
464+
/// <inheritdoc />
353465
public NetworkedVarColor(NetworkedVarSettings settings, Color value) : base(settings, value) { }
354466
}
355467

468+
/// <summary>
469+
/// A NetworkedVar that holds color32s and support serialization
470+
/// </summary>
356471
[Serializable]
357472
public class NetworkedVarColor32 : NetworkedVar<Color32>
358473
{
474+
/// <inheritdoc />
359475
public NetworkedVarColor32() { }
476+
/// <inheritdoc />
360477
public NetworkedVarColor32(NetworkedVarSettings settings) : base(settings) { }
478+
/// <inheritdoc />
361479
public NetworkedVarColor32(Color32 value) : base(value) { }
480+
/// <inheritdoc />
362481
public NetworkedVarColor32(NetworkedVarSettings settings, Color32 value) : base(settings, value) { }
363482
}
364483

484+
/// <summary>
485+
/// A NetworkedVar that holds rays and support serialization
486+
/// </summary>
365487
[Serializable]
366488
public class NetworkedVarRay : NetworkedVar<Ray>
367489
{
490+
/// <inheritdoc />
368491
public NetworkedVarRay() { }
492+
/// <inheritdoc />
369493
public NetworkedVarRay(NetworkedVarSettings settings) : base(settings) { }
494+
/// <inheritdoc />
370495
public NetworkedVarRay(Ray value) : base(value) { }
496+
/// <inheritdoc />
371497
public NetworkedVarRay(NetworkedVarSettings settings, Ray value) : base(settings, value) { }
372498
}
373499

500+
/// <summary>
501+
/// A NetworkedVar that holds quaternions and support serialization
502+
/// </summary>
374503
[Serializable]
375504
public class NetworkedVarQuaternion : NetworkedVar<Quaternion>
376505
{
506+
/// <inheritdoc />
377507
public NetworkedVarQuaternion() { }
508+
/// <inheritdoc />
378509
public NetworkedVarQuaternion(NetworkedVarSettings settings) : base(settings) { }
510+
/// <inheritdoc />
379511
public NetworkedVarQuaternion(Quaternion value) : base(value) { }
512+
/// <inheritdoc />
380513
public NetworkedVarQuaternion(NetworkedVarSettings settings, Quaternion value) : base(settings, value) { }
381514
}
382515
}

0 commit comments

Comments
 (0)