Commit bb9dbf1
authored
fix: connection approval cannot exceed mtu size - backport (3564) (#3565)
This PR resolves the issue where a NetworkConfig.ConnectionData that
caused the ConnectionRequestMessage to exceed the transport's MTU size
would result in a buffer overflow error by updating
ConnectionRequestMessage to use the ReliableFragmentedSequenced pipeline
as opposed to the ReliableSequenced pipeline.
[MTTB-1467](https://jira.unity3d.com/browse/MTTB-1467)
## Changelog
- Fixed: issue where NetworkConfig.ConnectionData could cause the
ConnectionRequestMessage to exceed the transport's MTU size and would
result in a buffer overflow error.
## Testing and Documentation
- Includes modifications to `ConnectionApproval` integration tests to
use a > MTU size `NetworkConfig.ConnectionData`.
- No documentation changes or additions were necessary.
## Backport
This is a back port of #3564.1 parent 2939f8b commit bb9dbf1
File tree
3 files changed
+19
-4
lines changed- com.unity.netcode.gameobjects
- Runtime/Connection
- Tests/Runtime
3 files changed
+19
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
13 | 23 | | |
14 | 24 | | |
15 | 25 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
626 | 626 | | |
627 | 627 | | |
628 | 628 | | |
629 | | - | |
| 629 | + | |
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
| |||
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| |||
0 commit comments