Make the default local update rate for NetworkedVars the global update rate

Prevent possibility of duplicate sends across the network by only sending when the NetworkedVars value actually changes.
Rename SendDelay to SendTickrate. This unifies the naming convention of the local update rate for NetworkedVar with the global update rate.

Author: MarcBritton

MLAPI/Data/NetworkedCollections/NetworkedDictionary.cs

@@ -221,8 +221,7 @@ public bool CanClientRead(uint clientId)
         public bool IsDirty()
         {
             if (dirtyEvents.Count == 0) return false;
-            if (Settings.SendOnChange) return true;
-            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendDelay) return true;
+            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendTickrate) return true;
             return false;
         }
 

MLAPI/Data/NetworkedCollections/NetworkedList.cs

@@ -51,8 +51,7 @@ public void ResetDirty()
         public bool IsDirty()
         {
             if (dirtyEvents.Count == 0) return false;
-            if (Settings.SendOnChange) return true;
-            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendDelay) return true;
+            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendTickrate) return true;
             return false;
         }
 

MLAPI/Data/NetworkedVar.cs

@@ -1,6 +1,8 @@
 using MLAPI.NetworkingManagerComponents.Binary;
 using MLAPI.MonoBehaviours.Core;
 using MLAPI.NetworkingManagerComponents.Core;
+using System;
+using System.Collections.Generic;
 
 namespace MLAPI.Data
 {
@@ -49,8 +51,11 @@ public T Value
             }
             set
             {
-                isDirty = true;
-                InternalValue = value;
+                if (!EqualityComparer<T>.Default.Equals(InternalValue, value))
+                {
+                    isDirty = true;
+                    InternalValue = value;
+                }
             }
         }
 
@@ -65,8 +70,7 @@ public void ResetDirty()
         public bool IsDirty()
         {
             if (!isDirty) return false;
-            if (Settings.SendOnChange) return true;
-            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendDelay) return true;
+            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendTickrate) return true;
             return false;
         }
 

MLAPI/Data/NetworkedVarMeta.cs

@@ -1,4 +1,5 @@
 using MLAPI.Data.Transports;
+using MLAPI.MonoBehaviours.Core;
 
 namespace MLAPI.Data
 {
@@ -24,13 +25,9 @@ public class NetworkedVarSettings
         /// </summary>
         public NetworkedVarPermissionsDelegate ReadPermissionCallback = null;
         /// <summary>
-        /// If enabled, sends will be sent the as fast as possible. If disabled, the sendDelay will be used
-        /// </summary>
-        public bool SendOnChange = false;
-        /// <summary>
         /// The minimum amount of delay in seconds between sends
         /// </summary>
-        public float SendDelay = 0.1f;
+        public float SendTickrate = NetworkingManager.singleton.NetworkConfig.SendTickrate;
         /// <summary>
         /// The name of the channel to use for this variable.
         /// Variables with different channels will be split into different packets