Skip to content

Commit bfef804

Browse files
committed
Updated PR trigger to not need comment trigger keyword
1 parent 088a6fd commit bfef804

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

.yamato/_triggers.yml

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,6 @@
4040

4141
#-----------------------------------------------------------------------------------
4242

43-
# Gates the merger of PRs as a pre-requisite. Runs when `/ci ngo` or `/ci ignore` is present as an issue comment
44-
# Notice that I needed this job to do "something" and that's why there is a placeholder GitHub action used
45-
# TODO: In the future we could have comment like "docs" or "project" to run a specific subset of tests
46-
check_pr_issue_comments_for_trigger_keywords:
47-
name: Check PR for trigger comments of ngo or ignore. For example /ci ngo
48-
agent:
49-
type: shell
50-
commands:
51-
- echo "This is a placeholder job. It exists only to gate PR merges based on issue comments"
52-
triggers:
53-
expression: |-
54-
pull_request.comment eq "ngo" OR
55-
pull_request.comment eq "ignore"
56-
5743

5844
# Run all relevant tasks when a pull request targeting the develop or release branch is created or updated.
5945
# In order to have better coverage we run desktop standalone tests with different configurations which allows to mostly cover for different platforms, scripting backends and editor versions.
@@ -82,9 +68,8 @@ pull_request_trigger:
8268
# TODO: consider setting up and running tests from Examples/
8369
# TODO: or docs only changes are spelling/link check
8470
expression: |-
85-
pull_request.comment eq "ngo" AND
86-
(pull_request.changes.any match "com.unity.netcode.gameobjects/**" OR
87-
pull_request.changes.any match "testproject/**")
71+
pull_request.changes.any match "com.unity.netcode.gameobjects/**" OR
72+
pull_request.changes.any match "testproject/**"
8873
cancel_old_ci: true
8974

9075
# Run all tests on 6000.2 (latest supported editor) on nightly basis.

0 commit comments

Comments
 (0)