Reduced GetValue reflection calls in NetworkedVar init

TwoTenPvP · TwoTenPvP · commit c5cbbc1863ce · 2018-07-10T13:25:07.000+02:00
diff --git a/MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs b/MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs
@@ -953,17 +953,14 @@ internal void NetworkedVarInit()
                 Type fieldType = sortedFields[i].FieldType;
                 if (fieldType.HasInterface(typeof(INetworkedVar)))
                 {
-                    INetworkedVar instance = null;
-                    if (sortedFields[i].GetValue(this) == null)
+                    INetworkedVar instance = (INetworkedVar)sortedFields[i].GetValue(this);
+                    if (instance == null)
                     {
                         Type genericType = fieldType.MakeGenericType(fieldType.GetGenericArguments());
                         instance = (INetworkedVar)Activator.CreateInstance(genericType, true);
                         sortedFields[i].SetValue(this, instance);
                     }
-                    else
-                    {
-                        instance = (INetworkedVar)sortedFields[i].GetValue(this);
-                    }
+                    
                     instance.SetNetworkedBehaviour(this);
                     networkedVarFields.Add(instance);
                 }

Original file line number	Diff line number	Diff line change
`@@ -953,17 +953,14 @@ internal void NetworkedVarInit()`
`953`	`953`	`Type fieldType = sortedFields[i].FieldType;`
`954`	`954`	`if (fieldType.HasInterface(typeof(INetworkedVar)))`
`955`	`955`	`{`
`956`		`- INetworkedVar instance = null;`
`957`		`- if (sortedFields[i].GetValue(this) == null)`
	`956`	`+ INetworkedVar instance = (INetworkedVar)sortedFields[i].GetValue(this);`
	`957`	`+ if (instance == null)`
`958`	`958`	`{`
`959`	`959`	`Type genericType = fieldType.MakeGenericType(fieldType.GetGenericArguments());`
`960`	`960`	`instance = (INetworkedVar)Activator.CreateInstance(genericType, true);`
`961`	`961`	`sortedFields[i].SetValue(this, instance);`
`962`	`962`	`}`
`963`		`- else`
`964`		`- {`
`965`		`- instance = (INetworkedVar)sortedFields[i].GetValue(this);`
`966`		`- }`
	`963`	`+`
`967`	`964`	`instance.SetNetworkedBehaviour(this);`
`968`	`965`	`networkedVarFields.Add(instance);`
`969`	`966`	`}`