Apply feedback

Author: EmandM

com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NetcodeIntegrationTest.cs

@@ -1910,13 +1910,11 @@ protected IEnumerator WaitForConditionOrTimeOut(Func<StringBuilder, bool> checkF
         /// <summary>
         /// Waits until the given NetworkObject is spawned on all clients or a timeout occurs.
         /// </summary>
-        /// <param name="instanceNetworkObject">The <see cref="NetworkObject"/> to watch for.</param>
+        /// <param name="networkObjectId">The id of the<see cref="NetworkObject"/> to wait for.</param>
         /// <param name="timeOutHelper">An optional <see cref="TimeoutHelper"/> to control the timeout period. If null, the default timeout is used.</param>
         /// <returns>An <see cref="IEnumerator"/> for use in Unity coroutines.</returns>
-        protected IEnumerator WaitForSpawnedOnAllOrTimeOut(NetworkObject instanceNetworkObject, TimeoutHelper timeOutHelper = null)
+        protected IEnumerator WaitForSpawnedOnAllOrTimeOut(ulong networkObjectId, TimeoutHelper timeOutHelper = null)
         {
-            var networkObjectId = instanceNetworkObject.GetComponent<NetworkObject>().NetworkObjectId;
-
             bool ValidateObjectSpawnedOnAllClients(StringBuilder errorLog)
             {
                 foreach (var client in m_NetworkManagers)
@@ -1933,6 +1931,18 @@ bool ValidateObjectSpawnedOnAllClients(StringBuilder errorLog)
             yield return WaitForConditionOrTimeOut(ValidateObjectSpawnedOnAllClients, timeOutHelper);
         }
 
+        /// <summary>
+        /// Waits until the given NetworkObject is spawned on all clients or a timeout occurs.
+        /// </summary>
+        /// <param name="networkObject">The <see cref="NetworkObject"/> to wait for.</param>
+        /// <param name="timeOutHelper">An optional <see cref="TimeoutHelper"/> to control the timeout period. If null, the default timeout is used.</param>
+        /// <returns>An <see cref="IEnumerator"/> for use in Unity coroutines.</returns>
+        protected IEnumerator WaitForSpawnedOnAllOrTimeOut(NetworkObject networkObject, TimeoutHelper timeOutHelper = null)
+        {
+            var networkObjectId = networkObject.GetComponent<NetworkObject>().NetworkObjectId;
+            yield return WaitForSpawnedOnAllOrTimeOut(networkObjectId, timeOutHelper);
+        }
+
         /// <summary>
         /// Validates that all remote clients (i.e. non-server) detect they are connected
         /// to the server and that the server reflects the appropriate number of clients