Skip to content

Commit da69b19

Browse files
fix: PVP errors
Fixing API documentation issues.
1 parent edf73f6 commit da69b19

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformBase.cs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,10 @@ protected bool AllChildObjectInstancesAreSpawned()
377377
return true;
378378
}
379379

380+
/// <summary>
381+
/// Conditional check that all child object instances also have a child
382+
/// </summary>
383+
/// <returns>true if they do and false if they do not</returns>
380384
protected bool AllFirstLevelChildObjectInstancesHaveChild()
381385
{
382386
foreach (var instance in ChildObjectComponent.ClientInstances.Values)
@@ -389,6 +393,10 @@ protected bool AllFirstLevelChildObjectInstancesHaveChild()
389393
return true;
390394
}
391395

396+
/// <summary>
397+
/// Conditional check that all child instances have a child.
398+
/// </summary>
399+
/// <returns>true if they do and false if they do not</returns>
392400
protected bool AllChildObjectInstancesHaveChild()
393401
{
394402
foreach (var instance in ChildObjectComponent.ClientInstances.Values)
@@ -411,6 +419,10 @@ protected bool AllChildObjectInstancesHaveChild()
411419
return true;
412420
}
413421

422+
/// <summary>
423+
/// Conditional check that all first level child objects have no parent.
424+
/// </summary>
425+
/// <returns>true if they do and false if they do not</returns>
414426
protected bool AllFirstLevelChildObjectInstancesHaveNoParent()
415427
{
416428
foreach (var instance in ChildObjectComponent.ClientInstances.Values)
@@ -423,6 +435,10 @@ protected bool AllFirstLevelChildObjectInstancesHaveNoParent()
423435
return true;
424436
}
425437

438+
/// <summary>
439+
/// Conditional check that all sub-child objects have no parent.
440+
/// </summary>
441+
/// <returns>true if they do and false if they do not</returns>
426442
protected bool AllSubChildObjectInstancesHaveNoParent()
427443
{
428444
if (ChildObjectComponent.HasSubChild)

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ private void UpdateTransformWorld(NetworkTransform networkTransformTestComponent
113113
/// This test is based on the v2.x SwitchTransformSpaceWhenParented test but only validates the ability for an owner to
114114
/// apply parenting locally in order to help synchronizing when parenting.
115115
/// </summary>
116+
/// <param name="scale">various scale values to be applied</param>
116117
[Test]
117118
public void OwnerParentingTest([Values(0.5f, 1.0f, 5.0f)] float scale)
118119
{

0 commit comments

Comments
 (0)