fix: memory leak without domain reload

NoelStephensUnity · web-flow · commit db586e07972e · 2025-04-25T10:49:33.000-05:00
playModeStateChanged never gets unsubscribed
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs
@@ -1303,6 +1303,9 @@ private void OnDestroy()
             {
                 Singleton = null;
             }
+#if UNITY_EDITOR
+            EditorApplication.playModeStateChanged -= ModeChanged;
+#endif            
         }
 
         // Command line options

Original file line number	Diff line number	Diff line change
`@@ -1303,6 +1303,9 @@ private void OnDestroy()`
`1303`	`1303`	`{`
`1304`	`1304`	`Singleton = null;`
`1305`	`1305`	`}`
	`1306`	`+#if UNITY_EDITOR`
	`1307`	`+ EditorApplication.playModeStateChanged -= ModeChanged;`
	`1308`	`+#endif`
`1306`	`1309`	`}`
`1307`	`1310`
`1308`	`1311`	`// Command line options`