Skip to content

Commit dd1a844

Browse files
committed
Update test to be more comprehensive
1 parent 822e3a2 commit dd1a844

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

com.unity.netcode.gameobjects/Tests/Runtime/Messaging/NamedMessageTests.cs

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,15 @@ public unsafe void ErrorMessageIsPrintedWhenAttemptingToSendNamedMessageWithTooB
284284
public void NamedMessageHandlerIsUnregisteredWithoutException()
285285
{
286286
var messageName = Guid.NewGuid().ToString();
287+
const int numMessagesToSend = 3;
288+
const int expectedMessageHandlerCallCount = 1;
287289

288-
var receivedMessageContent = new ForceNetworkSerializeByMemcpy<Guid>(new Guid());
290+
var messageHandlerCalled = 0;
289291
m_ServerNetworkManager.CustomMessagingManager.RegisterNamedMessageHandler(
290292
messageName,
291-
(_, reader) =>
293+
(_, _) =>
292294
{
293-
reader.ReadValueSafe(out receivedMessageContent);
295+
messageHandlerCalled++;
294296
m_ServerNetworkManager.CustomMessagingManager.UnregisterNamedMessageHandler(messageName);
295297
});
296298

@@ -299,13 +301,16 @@ public void NamedMessageHandlerIsUnregisteredWithoutException()
299301
using (writer)
300302
{
301303
writer.WriteValueSafe(messageContent);
302-
m_ServerNetworkManager.CustomMessagingManager.SendNamedMessage(
303-
messageName,
304-
m_ServerNetworkManager.LocalClientId,
305-
writer);
304+
for (var i = 0; i < numMessagesToSend; i++)
305+
{
306+
m_ServerNetworkManager.CustomMessagingManager.SendNamedMessage(
307+
messageName,
308+
m_ServerNetworkManager.LocalClientId,
309+
writer);
310+
}
306311
}
307312

308-
Assert.AreEqual(messageContent.Value, receivedMessageContent.Value);
313+
Assert.AreEqual(expectedMessageHandlerCallCount, messageHandlerCalled);
309314
}
310315
}
311316
}

0 commit comments

Comments
 (0)