chore: backport fixes to release1.0.0 (#1936)

* chore: Separate trunk tests and trigger weekly (#1926)

* chore: Separate trunk tests and trigger weekly

* Rename to weekly

* Turn off badges trigger dependencies on trunk

* Run Code Coverage on validation_editor 2020.3

* fix: Fix code coverage config name in nightly trigger (#1933)

* docs: NetworkConfig.ClientConnectionBufferTimeout xmldoc clarifications [skip ci] (#1927)

Add more detail to where in the process the setting takes effect, how it relates to transport-level timeouts and indicates that it's a server-side setting only.

* chore: update `CODEOWNERS` (#1935)

Co-authored-by: Jesse Olmer <[email protected]>
Co-authored-by: Fatih Mar <[email protected]>

Author: 3 people

.github/CODEOWNERS

@@ -1,6 +1,7 @@
 # see https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners for more information
 # Order is important; the last matching pattern takes the most precedence.
 
+* @Unity-Technologies/multiplayer-sdk
 Profiling/ @Unity-Technologies/multiplayer-tools
 Metrics/ @Unity-Technologies/multiplayer-tools
 /com.unity.netcode.gameobjects/Runtime/Transports/ @Unity-Technologies/multiplayer-server

.yamato/_run-all.yml

@@ -10,10 +10,28 @@ run_all_tests:
 {% for platform in test_platforms -%}
 {% for project in projects -%}
 {% for editor in project.test_editors -%}
+{% if editor != "trunk" -%}
 {% for package in project.packages -%}
     - .yamato/package-tests.yml#test_{{ project.name}}_{{ package.name }}_{{ editor }}_{{ platform.name }}
 {% endfor -%}
     - .yamato/project-tests.yml#test_{{ project.name }}_{{ editor }}_{{ platform.name }}
+{% endif -%}
+{% endfor -%}
+{% endfor -%}
+{% endfor -%}
+
+run_all_tests_trunk:
+  name: Run All Package and Project Tests [Trunk]
+  dependencies:
+{% for platform in test_platforms -%}
+{% for project in projects -%}
+{% for editor in project.test_editors -%}
+{% if editor == "trunk" -%}
+{% for package in project.packages -%}
+    - .yamato/package-tests.yml#test_{{ project.name}}_{{ package.name }}_{{ editor }}_{{ platform.name }}
+{% endfor -%}
+    - .yamato/project-tests.yml#test_{{ project.name }}_{{ editor }}_{{ platform.name }}
+{% endif -%}
 {% endfor -%}
 {% endfor -%}
 {% endfor -%}

.yamato/_triggers.yml

@@ -10,9 +10,19 @@ develop_nightly:
   dependencies:
     - .yamato/_run-all.yml#run_all_tests
 {% for project in projects -%}
-    - .yamato/code-coverage.yml#code_coverage_win_{{ project.name }}
+    - .yamato/code-coverage.yml#code_coverage_win_{{ project.name }}_{{ validation_editor }}
 {% endfor -%}
 
+develop_weekly_trunk:
+  name: "[Weekly] Run All Tests [Trunk]"
+  triggers:
+    recurring:
+    - branch: develop
+      frequency: weekly
+      rerun: always
+  dependencies:
+    - .yamato/_run-all.yml#run_all_tests_trunk
+
 multiprocess_nightly:
   name: "[Nightly] Run Multiprocess Tests"
   triggers:
@@ -77,9 +87,11 @@ badges_test_trigger:
     - .yamato/project-tests.yml#validate_{{ package.name }}_{{ test_platforms.first.name }}_{{ validation_editor }}
 {% endif -%}
 {% for editor in project.test_editors -%}
+{% if editor != "trunk" -%}
 {% for platform in test_platforms -%}
     - .yamato/package-tests.yml#test_{{ project.name }}_{{ package.name }}_{{ editor }}_{{ platform.name }}
 {% endfor -%}
+{% endif -%}
 {% endfor -%}
 {% endfor -%}
 {% endfor -%}

.yamato/code-coverage.yml

@@ -1,16 +1,16 @@
 {% metadata_file .yamato/project.metafile %}
 ---
 {% for project in projects -%}
-code_coverage_win_{{ project.name }}:
-  name: Code Coverage Report - Windows - {{ project.name }}
+code_coverage_win_{{ project.name }}_{{ validation_editor }}:
+  name: Code Coverage Report - Windows - {{ project.name }} - {{ validation_editor }}
   agent:
     type: Unity::VM
     image: package-ci/win10:stable
     flavor: b1.large
   commands:
     - pip install unity-downloader-cli --upgrade --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
     - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
-    - unity-downloader-cli -u trunk -c editor --wait --fast
+    - unity-downloader-cli -u {{ validation_editor }} -c editor --wait --fast
     - upm-ci package test -u .Editor --package-path com.unity.netcode.gameobjects --enable-code-coverage --code-coverage-options 'enableCyclomaticComplexity;generateAdditionalMetrics;generateHtmlReport;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime,+Unity.Netcode.Components'
   artifacts:
     logs:

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkConfig.cs

@@ -53,9 +53,21 @@ public class NetworkConfig
         public uint TickRate = 30;
 
         /// <summary>
-        /// The amount of seconds to wait for handshake to complete before timing out a client
+        /// The amount of seconds for the server to wait for the connection approval handshake to complete before the client is disconnected.
+        ///
+        /// If the timeout is reached before approval is completed the client will be disconnected.
         /// </summary>
-        [Tooltip("The amount of seconds to wait for the handshake to complete before the client times out")]
+        /// <remarks>
+        /// The period begins after the <see cref="NetworkEvent.Connect"/> is received on the server.
+        /// The period ends once the server finishes processing a <see cref="ConnectionRequestMessage"/> from the client.
+        ///
+        /// This setting is independent of any Transport-level timeouts that may be in effect. It covers the time between
+        /// the connection being established on the Transport layer, the client sending a
+        /// <see cref="ConnectionRequestMessage"/>, and the server processing that message through <see cref="ConnectionApproval"/>.
+        ///
+        /// This setting is server-side only.
+        /// </remarks>
+        [Tooltip("The amount of seconds for the server to wait for the connection approval handshake to complete before the client is disconnected")]
         public int ClientConnectionBufferTimeout = 10;
 
         /// <summary>