Skip to content

Commit e4a47a1

Browse files
committed
Added "run_quick_checks" job that will run the fastest checks and ONLY IF those will pass, it will run the rest of PR trigger dependencies
1 parent d295f92 commit e4a47a1

File tree

2 files changed

+27
-13
lines changed

2 files changed

+27
-13
lines changed

.yamato/_run-all.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,15 @@
1010

1111
#-----------------------------------------------------------------------------------
1212

13+
# This job runs the fastest checks (PVP and code standards)
14+
# This is mainly used to quickly validate the easy mistakes before for example running PR trigger jobs (see _triggers.yml)
15+
run_quick_checks:
16+
name: Run Quick Initial Checks
17+
dependencies:
18+
- .yamato/package-pack.yml#package_pack_-_ngo_win
19+
- .yamato/package-pack.yml#package_pack_-_ngo_mac
20+
- .yamato/package-pack.yml#package_pack_-_ngo_ubuntu
21+
- .yamato/project-standards.yml#standards_win_testproject_6000.0
1322

1423
# Runs all package tests
1524
run_all_package_tests:

.yamato/_triggers.yml

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,22 +40,27 @@
4040

4141
# Run all relevant tasks when a pull request targeting the develop or release branch is created or updated.
4242
# In order to have better coverage we run desktop standalone tests with different configurations which allows to mostly cover for different platforms, scripting backends and editor versions.
43+
# This job will FIRST run "run_quick_checks" jobs (defined in _run-all.yml) which runs the fastest checks (like PVP or code standards) and ONLY IF those pass it will run the rest of the tests.
44+
# This optimization allows to speed up feedback look for any "obvious" errors and save resources.
4345
pull_request_trigger:
4446
name: Pull Request Trigger (develop, develop-2.0.0, & release branches)
4547
dependencies:
46-
# Run project standards to verify package/default project. This is fine to just run for trunk
47-
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
48-
# Run package EditMode and Playmode package tests on trunk
49-
- .yamato/_run-all.yml#run_all_package_tests_trunk
50-
# Run package EditMode and Playmode package tests on minimum supported editor (6000.0 in case of NGOv2.X)
51-
- .yamato/_run-all.yml#run_all_package_tests_6000
52-
# Run project EditMode and PLaymode project tests on trunk
53-
- .yamato/_run-all.yml#run_all_project_tests_trunk
54-
# Run project EditMode and PLaymode project tests on minimum supported editor (6000.0 in case of NGOv2.X)
55-
- .yamato/_run-all.yml#run_all_project_tests_6000
56-
# Run standalone test with mixture of parameters to make sure there are no obvious issues with most common platform (for example --fail-on-assert option is not present with package/project tests). We run 2 different combinations with different platform/editor/scripting backend.
57-
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_mac_il2cpp_trunk
58-
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_win_mono_6000.0
48+
- .yamato/_run-all.yml#run_quick_checks
49+
- expression: dependencies.run_quick_checks.status == "success"
50+
dependencies:
51+
# Run project standards to verify package/default project. This is fine to just run for trunk
52+
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
53+
# Run package EditMode and Playmode package tests on trunk
54+
- .yamato/_run-all.yml#run_all_package_tests_trunk
55+
# Run package EditMode and Playmode package tests on minimum supported editor (6000.0 in case of NGOv2.X)
56+
- .yamato/_run-all.yml#run_all_package_tests_6000
57+
# Run project EditMode and PLaymode project tests on trunk
58+
- .yamato/_run-all.yml#run_all_project_tests_trunk
59+
# Run project EditMode and PLaymode project tests on minimum supported editor (6000.0 in case of NGOv2.X)
60+
- .yamato/_run-all.yml#run_all_project_tests_6000
61+
# Run standalone test with mixture of parameters to make sure there are no obvious issues with most common platform (for example --fail-on-assert option is not present with package/project tests). We run 2 different combinations with different platform/editor/scripting backend.
62+
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_mac_il2cpp_trunk
63+
- .yamato/desktop-standalone-tests.yml#desktop_standalone_test_testproject_win_mono_6000.0
5964
triggers:
6065
cancel_old_ci: true
6166
pull_requests:

0 commit comments

Comments
 (0)