Skip to content

Commit f369d09

Browse files
update - pvp
Fixing the remainder of the PVP issues within the components area.
1 parent 639fbf8 commit f369d09

File tree

5 files changed

+6
-29
lines changed

5 files changed

+6
-29
lines changed

com.unity.netcode.gameobjects/Runtime/Components/HalfVector3.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ private void SerializeRead(FastBufferReader reader)
7474
}
7575
}
7676

77-
/// <summary>
78-
/// The serialization implementation of <see cref="INetworkSerializable"/>.
79-
/// </summary>
77+
/// <inheritdoc />
8078
public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter
8179
{
8280
if (serializer.IsReader)

com.unity.netcode.gameobjects/Runtime/Components/HalfVector4.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ private void SerializeRead(FastBufferReader reader)
5858
}
5959
}
6060

61-
/// <summary>
62-
/// The serialization implementation of <see cref="INetworkSerializable"/>.
63-
/// </summary>
61+
/// <inheritdoc />
6462
public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter
6563
{
6664
if (serializer.IsReader)

com.unity.netcode.gameobjects/Runtime/Components/Interpolator/BufferedLinearInterpolator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ protected internal struct BufferedItem
3232
public double TimeSent;
3333

3434
/// <summary>
35-
/// The constructor
35+
/// The constructor.
3636
/// </summary>
3737
/// <param name="item">The item value.</param>
3838
/// <param name="timeSent">The time the item was sent.</param>

com.unity.netcode.gameobjects/Runtime/Components/NetworkDeltaPosition.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ public struct NetworkDeltaPosition : INetworkSerializable
2727

2828
internal bool CollapsedDeltaIntoBase;
2929

30-
/// <summary>
31-
/// The serialization implementation of <see cref="INetworkSerializable"/>
32-
/// </summary>
30+
/// <inheritdoc />
3331
public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter
3432
{
3533
if (!SynchronizeBase)
@@ -105,6 +103,7 @@ public Vector3 GetFullPosition()
105103
/// <remarks>
106104
/// Only applies to the authoritative side for <see cref="NetworkTransform"/> instances.
107105
/// </remarks>
106+
/// <returns>Returns the half float <see cref="Vector3"/> version of the current delta position.</returns>
108107
[MethodImpl(MethodImplOptions.AggressiveInlining)]
109108
public Vector3 GetConvertedDelta()
110109
{
@@ -120,6 +119,7 @@ public Vector3 GetConvertedDelta()
120119
/// Precision loss adjustments are one network tick behind on the
121120
/// non-authoritative side.
122121
/// </remarks>
122+
/// <returns>The full precision delta position value as a <see cref="Vector3"/>.</returns>
123123
[MethodImpl(MethodImplOptions.AggressiveInlining)]
124124
public Vector3 GetDeltaPosition()
125125
{

pvpExceptions.json

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -26,25 +26,6 @@
2626
"Unity.Netcode.Components.AnticipatedNetworkTransform.TransformState: Position: undocumented",
2727
"Unity.Netcode.Components.AnticipatedNetworkTransform.TransformState: Rotation: undocumented",
2828
"Unity.Netcode.Components.AnticipatedNetworkTransform.TransformState: Scale: undocumented",
29-
"Unity.Netcode.Components.HalfVector3: void NetworkSerialize(BufferSerializer<T>): missing <param name=\"serializer\">",
30-
"Unity.Netcode.Components.HalfVector3: void NetworkSerialize(BufferSerializer<T>): missing <typeparam name=\"T\">",
31-
"Unity.Netcode.Components.HalfVector4: void NetworkSerialize(BufferSerializer<T>): missing <param name=\"serializer\">",
32-
"Unity.Netcode.Components.HalfVector4: void NetworkSerialize(BufferSerializer<T>): missing <typeparam name=\"T\">",
33-
"Unity.Netcode.BufferedLinearInterpolator<T>: m_InterpStartValue: undocumented",
34-
"Unity.Netcode.BufferedLinearInterpolator<T>: m_CurrentInterpValue: undocumented",
35-
"Unity.Netcode.BufferedLinearInterpolator<T>: m_InterpEndValue: undocumented",
36-
"Unity.Netcode.BufferedLinearInterpolator<T>: m_Buffer: undocumented",
37-
"Unity.Netcode.BufferedLinearInterpolator<T>: void OnConvertTransformSpace(Transform, bool): undocumented",
38-
"Unity.Netcode.BufferedLinearInterpolator<T>.BufferedItem: undocumented",
39-
"Unity.Netcode.BufferedLinearInterpolator<T>.BufferedItem: Item: undocumented",
40-
"Unity.Netcode.BufferedLinearInterpolator<T>.BufferedItem: TimeSent: undocumented",
41-
"Unity.Netcode.BufferedLinearInterpolator<T>.BufferedItem: .ctor(T, double): undocumented",
42-
"Unity.Netcode.BufferedLinearInterpolatorQuaternion: void OnConvertTransformSpace(Transform, bool): undocumented",
43-
"Unity.Netcode.BufferedLinearInterpolatorVector3: void OnConvertTransformSpace(Transform, bool): undocumented",
44-
"Unity.Netcode.Components.NetworkDeltaPosition: void NetworkSerialize(BufferSerializer<T>): missing <param name=\"serializer\">",
45-
"Unity.Netcode.Components.NetworkDeltaPosition: void NetworkSerialize(BufferSerializer<T>): missing <typeparam name=\"T\">",
46-
"Unity.Netcode.Components.NetworkDeltaPosition: Vector3 GetConvertedDelta(): missing <returns>",
47-
"Unity.Netcode.Components.NetworkDeltaPosition: Vector3 GetDeltaPosition(): missing <returns>",
4829
"Unity.Netcode.NetworkConfig: Prefabs: undocumented",
4930
"Unity.Netcode.NetworkConfig: NetworkTopology: undocumented",
5031
"Unity.Netcode.NetworkConfig: UseCMBService: undocumented",

0 commit comments

Comments
 (0)