Laid out more flow code

Author: TwoTenPvP

MLAPI/Data/NetworkedVar.cs

@@ -29,27 +29,22 @@ public T Value
             }
             set
             {
-                if (Settings.SendOnChange)
-                {
-                    IsDirty = false;
-                    LastSyncedTime = NetworkingManager.singleton.NetworkTime;
-                    InternalValue = value;
-                    //TODO: Send
-                }
-                else
-                {
-                    InternalValue = value;
-                    IsDirty = true;
-                }
+                IsDirty = true;
+                InternalValue = value;
             }
         }
 
-        bool INetworkedVar.NeedsDirtySync()
+        void INetworkedVar.OnSynced()
         {
-            if (!IsDirty && !Settings.SendOnChange && NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendDelay)
-            {
-                IsDirty = true;
-            }
+            IsDirty = false;
+            LastSyncedTime = NetworkingManager.singleton.NetworkTime;
+        }
+
+        bool INetworkedVar.IsDirty()
+        {
+            if (!IsDirty) return false;
+            if (Settings.SendOnChange) return true;
+            if (NetworkingManager.singleton.NetworkTime - LastSyncedTime >= Settings.SendDelay) return true;
             return IsDirty;
         }
 
@@ -100,7 +95,7 @@ void INetworkedVar.SetNetworkedBehaviour(NetworkedBehaviour behaviour)
         void INetworkedVar.SetFieldFromReader(BitReader reader)
         {
             // TODO TwoTen - Boxing sucks
-            T newValue = (T)FieldTypeHelper.ReadFieldType(reader, typeof(T), (object)InternalValue);
+            InternalValue = (T)FieldTypeHelper.ReadFieldType(reader, typeof(T), (object)InternalValue);
         }
 
         void INetworkedVar.WriteFieldToWriter(BitWriter writer)
@@ -109,9 +104,10 @@ void INetworkedVar.WriteFieldToWriter(BitWriter writer)
         }
     }
 
-    internal interface INetworkedVar
+    public interface INetworkedVar
     {
-        bool NeedsDirtySync();
+        void OnSynced();
+        bool IsDirty();
         bool CanClientWrite(uint clientId);
         bool CanClientRead(uint clientId);
         void WriteFieldToWriter(BitWriter writer);

MLAPI/MonoBehaviours/Core/NetworkedBehaviour.cs

@@ -953,6 +953,17 @@ internal void NetworkedVarInit()
             }
         }
 
+        internal void NetworkedVarPrepareSend()
+        {
+            //TODO: Loop all the fields, write dirty fields and send them to the transport.
+            //TODO: Do this efficiently.
+            //Avoid: One loop for the networkedFields and then one per client per networkedField iteration.
+            
+            //Flow:
+            //Check if dirty, send to clients that have read access
+            //Call OnSynced
+        }
+
         internal void HandleNetworkedVarChangedByRemote(BitReader reader)
         {
             ushort index = reader.ReadUShort();

MLAPI/MonoBehaviours/Core/NetworkedObject.cs

@@ -281,6 +281,14 @@ internal static void InvokeSyncvarUpdate()
             }
         }
 
+        internal static void NetworkedVarPrepareSend()
+        {
+            for (int i = 0; i < NetworkedBehaviours.Count; i++)
+            {
+                NetworkedBehaviours[i].NetworkedVarPrepareSend();
+            }
+        }
+
 
         //Writes SyncedVar data in a formatted way so that the SetFormattedSyncedVarData method can read it.
         //The format doesn't NECCECARLY correspond with the "general syncedVar message layout" 

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -640,6 +640,7 @@ private void Update()
             {
                 if((NetworkTime - lastSendTickTime >= (1f / NetworkConfig.SendTickrate)) || NetworkConfig.SendTickrate <= 0)
                 {
+                    NetworkedObject.NetworkedVarPrepareSend();
                     foreach (KeyValuePair<uint, NetworkedClient> pair in ConnectedClients)
                     {
                         byte error;