serialize the Vector3 and Quaternion directly

Author: EmandM

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -10,6 +10,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Added
 
+- Added serializer for `Pose` (#2675)
 - Added mappings between `ClientId` and `TransportId`. (#3515)
 - Added `SinglePlayerTransport` that provides the ability to start as a host for a single player network session. (#3475)
 - When using UnityTransport >=2.4 and Unity >= 6000.1.0a1, SetConnectionData will accept a fully qualified hostname instead of an IP as a connect address on the client side. (#3440)
@@ -34,7 +35,6 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Added `NetworkManager.OnPreShutdown` which is called before the NetworkManager cleans up and shuts down. (#3358)
 - Added `FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator)` constructor that uses the `ArraySegment.Offset` as the `FastBufferReader` offset and the `ArraySegment.Count` as the `FastBufferReader` length. (#3320)
 - Added `FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator, int length = -1)` constructor that uses the `ArraySegment.Offset` as the `FastBufferReader` offset. (#3320)
-- Added serializer for `Pose` (#2675)
 
 ### Fixed
 

com.unity.netcode.gameobjects/Runtime/Serialization/BytePacker.cs

@@ -267,13 +267,8 @@ public static void WriteValuePacked(FastBufferWriter writer, Quaternion rotation
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static void WriteValuePacked(FastBufferWriter writer, Pose pose)
         {
-            WriteValuePacked(writer, pose.position.x);
-            WriteValuePacked(writer, pose.position.y);
-            WriteValuePacked(writer, pose.position.z);
-            WriteValuePacked(writer, pose.rotation.x);
-            WriteValuePacked(writer, pose.rotation.y);
-            WriteValuePacked(writer, pose.rotation.z);
-            WriteValuePacked(writer, pose.rotation.w);
+            WriteValuePacked(writer, pose.position);
+            WriteValuePacked(writer, pose.rotation);
         }
 
         /// <summary>

com.unity.netcode.gameobjects/Runtime/Serialization/ByteUnpacker.cs

@@ -286,14 +286,9 @@ public static void ReadValuePacked(FastBufferReader reader, out Quaternion rotat
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static void ReadValuePacked(FastBufferReader reader, out Pose pose)
         {
-            pose = new Pose();
-            ReadValuePacked(reader, out pose.position.x);
-            ReadValuePacked(reader, out pose.position.y);
-            ReadValuePacked(reader, out pose.position.z);
-            ReadValuePacked(reader, out pose.rotation.x);
-            ReadValuePacked(reader, out pose.rotation.y);
-            ReadValuePacked(reader, out pose.rotation.z);
-            ReadValuePacked(reader, out pose.rotation.w);
+            ReadValuePacked(reader, out Vector3 position);
+            ReadValuePacked(reader, out Quaternion rotation);
+            pose = new Pose(position, rotation);
         }
 
         /// <summary>

com.unity.netcode.gameobjects/Tests/Editor/Serialization/FastBufferReaderTests.cs

@@ -460,7 +460,7 @@ protected override unsafe void RunTypeTest<T>(T valueToTest)
                 }
             }
         }
-        
+
         protected override unsafe void RunTypeTestSafe<T>(T valueToTest)
         {
             var writeSize = FastBufferWriter.GetWriteSize(valueToTest);

com.unity.netcode.gameobjects/Tests/Runtime/Components/NetworkVariableTestComponent.cs

@@ -283,7 +283,7 @@ private void InitializeTest()
             m_NetworkVariableLong = new NetworkVariable<long>(1);
             m_NetworkVariableSByte = new NetworkVariable<sbyte>(0);
             m_NetworkVariableQuaternion = new NetworkVariable<Quaternion>(Quaternion.identity);
-            m_NetworkVariablePose = new NetworkVariable<Pose>(Pose.identity);
+            m_NetworkVariablePose = new NetworkVariable<Pose>(new Pose(new Vector3(1, 1, 1), Quaternion.identity));
             m_NetworkVariableShort = new NetworkVariable<short>(256);
             m_NetworkVariableVector4 = new NetworkVariable<Vector4>(new Vector4(1, 1, 1, 1));
             m_NetworkVariableVector3 = new NetworkVariable<Vector3>(new Vector3(1, 1, 1));