Skip to content

Conversation

jonathanhertz
Copy link
Contributor

@jonathanhertz jonathanhertz commented Mar 26, 2025

Adds a filter.yml file that filters out tests from the pvp API documentation checks automatically. This prevents us from having to add a pvpException for all namespaces that contain Test in the name.

@jonathanhertz jonathanhertz requested a review from a team as a code owner March 26, 2025 10:22
@jonathanhertz jonathanhertz changed the title Add filter.yml docs: Add filter.yml Mar 26, 2025
Copy link
Collaborator

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But if I understand correctly those exceptions should still be present pets.pvp-catalog right (for release purposes)?

@michalChrobot
Copy link
Collaborator

Actually as I was talking with @NoelStephensUnity we want to make those Test related APIs internal which should resolve this problem without having filter.yml (otherwise a nice solution) so I would hold for a bit with merging and I will follow up on this

@michalChrobot
Copy link
Collaborator

We got approval to change the test classes to internal for the next release which should fix the problem. I will close this PR and I will come back to it IF we will have some problems with doing the change (then this would be a next in line solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants