Skip to content

Conversation

@simon-lemay-unity
Copy link
Contributor

There used to be a time when NGO supported both UTP 1.X and 2.X, which led to the use of defines like UTP_TRANSPORT_2_0_ABOVE to gate features that were only usable with UTP 2.X (or by proxy to differentiate code that was different for collections 1.X verus 2.X). In some files (like UnityTransport.cs) these defines are used abundantly, to the point of impacting code readability.

But NGO 2.X now depends on UTP 2.X, so these defines are now useless since they'll always be defined. This PR thus removes them. Functionally speaking this PR should change absolutely nothing since it just removes code that was never compiled anyway.

Changelog

N/A

Testing and Documentation

  • No tests have been added (in fact some were removed).
  • No documentation changes or additions were necessary.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 25, 2025

CLA assistant check
All committers have signed the CLA.

@simon-lemay-unity simon-lemay-unity changed the title cleanup: Remove defines based on UTP version refactor: Remove defines based on UTP version Mar 25, 2025
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of things and stuff removed!

@NoelStephensUnity NoelStephensUnity merged commit e3189a2 into develop-2.0.0 Mar 26, 2025
27 checks passed
@NoelStephensUnity NoelStephensUnity deleted the cleanup/remove-utp-defines branch March 26, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants