Skip to content

fix: network time system tests should use double fixed delta time #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

fix: network time system tests should use double fixed delta time #3373

merged 3 commits into from
Apr 1, 2025

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Mar 31, 2025

Adding the support to use a double delta time for NetworkTimeSystemTests.

Changelog

NA

Testing and Documentation

  • Includes update to the NetworkTimeSystemTests.CorrectAmountTicksTest integration test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
ac013c2 
Adding NetworkTime.FixedDeltaTimeAsDouble property to provide a double version of the NetworkTime.FixedDeltaTime.
@NoelStephensUnity
test
c793369 
Updating the `NetworkTimeSystemTests.CorrectAmountTicksTest` to use the `NetworkTime.FixedDeltaTimeAsDouble` as opposed to the `NetworkTime.FixedDeltaTime`. Adding additional debug information in the event it fails in the future we will have more information.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner March 31, 2025 22:03
@NoelStephensUnity NoelStephensUnity mentioned this pull request Mar 31, 2025
Merged
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 31, 2025 22:08
michalChrobot
michalChrobot approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoelStephensUnity NoelStephensUnity merged commit b6d32f0 into develop Apr 1, 2025
40 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/NetworkTimeSystemTests-should-use-doubles branch April 1, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalChrobot michalChrobot michalChrobot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NoelStephensUnity @michalChrobot @netcode-ci-service