Skip to content

chore: update the NetworkTransform state optimizations #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: develop-2.0.0
Choose a base branch
from
Open

chore: update the NetworkTransform state optimizations #3798

wants to merge 30 commits into from
+972 −677

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Nov 21, 2025 •
edited
Loading

Purpose of this PR

Provide an alternate way to handle this (pending standards for public API passing).

Jira ticket

NA

Changelog

NA

Documentation

NA

Testing & QA (How your changes can be verified during release Playtest)

NA

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port needed

EmandM and others added 21 commits October 31, 2025 13:23
@EmandM
chore: optimize bitflags in NetworkTransformState
cd11ac6
@EmandM
Update CHANGELOG
c938e7f
@NoelStephensUnity
Update IgnoreIfServiceEnvironmentVariableSetAttribute.cs
a341119
@EmandM @NoelStephensUnity
Apply suggestions from code review
85785bc 
Co-authored-by: Noel Stephens <[email protected]>
@NoelStephensUnity
style
cc5d84b 
removing and adding whitespaces.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into chore/optimize-network-transform-state
e5c6481
@NoelStephensUnity
update
8cae595 
Merge fix.
@EmandM
Fix cumulative state
3ac1439
@EmandM
Merge branch 'develop-2.0.0' into chore/optimize-network-transform-state
7947790
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
325dd3d
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
8e9e353
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
1ddc91a
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
e9118f1
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
10e69a0
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
e9bb5dc
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
d56bc4c
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
a0a9891
@netcode-ci-service
Merge develop-2.0.0 into chore/optimize-network-transform-state
077a6ba
@EmandM
Fix whitespace issue
25ca971
@NoelStephensUnity
fix
72ab763 
Fixing AnticipatedNetworkTransform m_NetworkManager issue.
@NoelStephensUnity
refactor
349f83e 
Refactoring how we handle updating public facing flags.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner November 21, 2025 21:55
@NoelStephensUnity NoelStephensUnity changed the base branch from chore/optimize-network-transform-state to develop-2.0.0 November 21, 2025 21:55
@NoelStephensUnity
update
d09cb92 
adding comment
@NoelStephensUnity
update
d15b193 
Updating some tests with these changes
(WIP) Migrating away from direct transform access and using a cached transform approach.
@NoelStephensUnity
refactor
3f98489 
Migrating all of the flags into FlagStates.
Migrating the bit serialization into FlagStates.
Migrating flag helper methods into FlagStates.
@NoelStephensUnity
fix
09f6bb2 
This resolves the issue with the EntityId no longer supporting integer conversion.
@NoelStephensUnity
style
45c8886 
removing partial comment and whitespace.
@NoelStephensUnity
fix
e9787b2 
Another spot where EntityId was needed.
@NoelStephensUnity
update
f7dee36 
Missed SwitchTransformSpaceWhenParented.
@NoelStephensUnity
refactor - EntityId
ffd986f 
Since MP Tools subscribes to the TransportInitialized and TransportDisposed methods and we have to vet against packages with dependencies, I am putting a temporary work-around to get past this issue so we can land the EntityId fix.
Once MP Tools is updated for EntityId, we can re-enable the original fix.
@NoelStephensUnity
update
e9fd51d 
Found a few more places that could be micro-optimized.
Fixing missed transformToUse that was if-def'd out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NoelStephensUnity @EmandM @netcode-ci-service