Fix warnings (#38)

* Fixing compilation warnings and ensure warnings are treated as errors in test projects.

* Updating changelog

Author: JonathanHUnity

TestProjects/PerceptionHDRP/Assets/csc.rsp

@@ -0,0 +1 @@
+-warnaserror+

TestProjects/PerceptionHDRP/Assets/csc.rsp.meta

@@ -5,7 +5,7 @@
 [RequireComponent(typeof(PerceptionCamera))]
 public class CustomAnnotationAndMetricReporter : MonoBehaviour
 {
-    public GameObject light;
+    public GameObject targetLight;
     public GameObject target;
 
     MetricDefinition lightMetricDefinition;
@@ -28,7 +28,7 @@ public void Start()
     public void Update()
     {
         //Report the light's position by manually creating the json array string.
-        var lightPos = light.transform.position;
+        var lightPos = targetLight.transform.position;
         DatasetCapture.ReportMetric(lightMetricDefinition,
             $@"[{{ ""x"": {lightPos.x}, ""y"": {lightPos.y}, ""z"": {lightPos.z} }}]");
         //compute the location of the object in the camera's local space

TestProjects/PerceptionURP/Assets/ExampleScripts/CustomAnnotationAndMetricReporter.cs

@@ -0,0 +1 @@
+-warnaserror+

TestProjects/PerceptionURP/Assets/csc.rsp

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Removed
 
 ### Fixed
+Fixed compilation warnings with latest com.unity.simulation.core package.
 
 ### Security
 

TestProjects/PerceptionURP/Assets/csc.rsp.meta

@@ -26,7 +26,7 @@ using UnityEngine.Perception.GroundTruth;
 [RequireComponent(typeof(PerceptionCamera))]
 public class CustomAnnotationAndMetricReporter : MonoBehaviour
 {
-    public GameObject light;
+    public GameObject targetLight;
     public GameObject target;
 
     MetricDefinition lightMetricDefinition;
@@ -49,7 +49,7 @@ public class CustomAnnotationAndMetricReporter : MonoBehaviour
     public void Update()
     {
         //Report the light's position by manually creating the json array string.
-        var lightPos = light.transform.position;
+        var lightPos = targetLight.transform.position;
         DatasetCapture.ReportMetric(lightMetricDefinition,
             $@"[{{ ""x"": {lightPos.x}, ""y"": {lightPos.y}, ""z"": {lightPos.z} }}]");
         //compute the location of the object in the camera's local space

com.unity.perception/CHANGELOG.md

@@ -193,7 +193,7 @@ void OnSemanticSegmentationImageRead(int frameCount, NativeArray<Color32> data)
                 height = targetTexture.height,
                 path = localPath
             };
-            asyncRequest.Start((r) =>
+            asyncRequest.Enqueue((r) =>
             {
                 Profiler.BeginSample("Encode");
                 var pngBytes = ImageConversion.EncodeArrayToPNG(r.data.data.ToArray(), GraphicsFormat.R8G8B8A8_UNorm, (uint)r.data.width, (uint)r.data.height);
@@ -205,6 +205,7 @@ void OnSemanticSegmentationImageRead(int frameCount, NativeArray<Color32> data)
                 r.data.data.Dispose();
                 return AsyncRequest.Result.Completed;
             });
+            asyncRequest.Execute();
         }
 
         /// <inheritdoc/>

com.unity.perception/Documentation~/DatasetCapture.md

@@ -63,8 +63,11 @@ public void AddScriptableRenderPass(ScriptableRenderPass pass)
 
         bool m_CapturedLastFrame;
         Ego m_EgoMarker;
+
+#pragma warning disable 414
         //only used to confirm that GroundTruthRendererFeature is present in URP
         bool m_GroundTruthRendererFeatureRun;
+#pragma warning restore 414
 
         /// <summary>
         /// The <see cref="SensorHandle"/> associated with this camera. Use this to report additional annotations and metrics at runtime.
@@ -171,7 +174,7 @@ void CaptureRgbData(Camera cam)
                 using (s_WriteFrame.Auto())
                 {
                     var dataColorBuffer = (byte[])r.data.colorBuffer;
-                    
+
                     byte[] encodedData;
                     using (s_EncodeAndSave.Auto())
                     {

com.unity.perception/Runtime/GroundTruth/Labelers/SemanticSegmentationLabeler.cs

@@ -188,11 +188,12 @@ void Write(List<PendingCapture> pendingCaptures, SimulationState simulationState
                     PendingCaptures = pendingCapturesToWrite,
                     SimulationState = this
                 };
-                req.Start(r =>
+                req.Enqueue(r =>
                 {
                     Write(r.data.PendingCaptures, r.data.SimulationState, r.data.CaptureFileIndex);
                     return AsyncRequest.Result.Completed;
                 });
+                req.Execute(AsyncRequest.ExecutionContext.JobSystem);
             }
 
             m_SerializeCapturesSampler.End();
@@ -256,11 +257,12 @@ void Write(List<PendingMetric> pendingMetrics, int metricsFileIndex)
                     MetricFileIndex = m_MetricsFileIndex,
                     PendingMetrics = pendingMetricsToWrite
                 };
-                req.Start(r =>
+                req.Enqueue(r =>
                 {
                     Write(r.data.PendingMetrics, r.data.MetricFileIndex);
                     return AsyncRequest.Result.Completed;
                 });
+                req.Execute();
             }
 
             m_MetricsFileIndex++;