Merge pull request #357 from Unity-Technologies/fix_label_config_editor_indexing

Fixed an indexing issue with the Id Label Config editor

Author: mkamalza

TestProjects/PerceptionURP/Assets/Tests/Editor/PerceptionCameraEditorUrpTests.cs

@@ -42,7 +42,6 @@ public IEnumerator MissingRendererFeature_ProducesLogError()
             gameObject.SetActive(false);
             gameObject.AddComponent<Camera>();
             gameObject.AddComponent<UniversalAdditionalCameraData>();
-
             var perceptionCamera = gameObject.AddComponent<PerceptionCamera>();
             gameObject.SetActive(true);
             LogAssert.Expect(LogType.Error, "GroundTruthRendererFeature must be present on the ScriptableRenderer associated with the camera. The ScriptableRenderer can be accessed through Edit -> Project Settings... -> Graphics -> Scriptable Render Pipeline Settings -> Renderer List.");

com.unity.perception/CHANGELOG.md

@@ -12,9 +12,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Known Issues
 
 ### Added
-User can now choose the base folder location to store their generated data.
 
-Added 'projection' field in the capture.sensor metadata. Values are either "perspective" or "orthographic"
+The user can now choose the base folder location to store their generated datasets.
+
+Added a `projection` field in the capture.sensor metadata. Values are either "perspective" or "orthographic".
 
 ### Changed
 
@@ -26,6 +27,8 @@ Changed the JSON serialization key of Normal Sampler's standard deviation proper
 
 ### Fixed
 
+Fixed an indexing issue with the IdLabelConfig editor. When a new label was added to an empty Id Label Config with Auto Assign IDs enabled, the starting id (0 or 1) was ignored and the new label would always have an id of 0.
+
 ## [0.8.0-preview.4] - 2021-07-05
 
 ### Upgrade Notes

com.unity.perception/Editor/GroundTruth/IdLabelConfigEditor.cs

@@ -149,16 +149,24 @@ void BindItem(VisualElement e, int i)
         protected override IdLabelEntry CreateLabelEntryFromLabelString(SerializedProperty serializedArray,
             string labelToAdd)
         {
-            int maxLabel = Int32.MinValue;
+            var maxLabel = int.MinValue;
             if (serializedArray.arraySize == 0)
                 maxLabel = -1;
 
-            for (int i = 0; i < serializedArray.arraySize; i++)
+            for (var i = 0; i < serializedArray.arraySize; i++)
             {
                 var item = serializedArray.GetArrayElementAtIndex(i);
                 maxLabel = math.max(maxLabel, item.FindPropertyRelative(nameof(IdLabelEntry.id)).intValue);
             }
 
+            if (maxLabel == -1)
+            {
+                var startingLabelId =
+                    (StartingLabelId) serializedObject.FindProperty(nameof(IdLabelConfig.startingLabelId)).enumValueIndex;
+                if (startingLabelId == StartingLabelId.One)
+                    maxLabel = 0;
+            }
+
             return new IdLabelEntry
             {
                 id = maxLabel + 1,

com.unity.perception/package.json

@@ -25,4 +25,4 @@
       "path": "Samples~/Human Pose Labeling and Randomization"
     }
   ]
-}
+}