Fixing wrong colors in semantic segmentation due to sRGB conversion by changing the shader parameter to a Vector, bypassing sRGB conversion altogether. (#46)

Author: JonathanHUnity

com.unity.perception/Runtime/GroundTruth/Labelers/SemanticSegmentationLabeler.cs

@@ -128,11 +128,18 @@ protected override void Setup()
 
             m_AsyncAnnotations = new Dictionary<int, AsyncAnnotation>();
 
-            var renderTextureDescriptor = new RenderTextureDescriptor(width, height, GraphicsFormat.R8G8B8A8_UNorm, 8);
             if (targetTexture != null)
+            {
+                if (targetTexture.sRGB)
+                {
+                    Debug.LogError("targetTexture supplied to SemanticSegmentationLabeler must be in Linear mode. Disabling labeler.");
+                    this.enabled = false;
+                }
+                var renderTextureDescriptor = new RenderTextureDescriptor(width, height, GraphicsFormat.R8G8B8A8_UNorm, 8);
                 targetTexture.descriptor = renderTextureDescriptor;
+            }
             else
-                m_TargetTextureOverride = new RenderTexture(renderTextureDescriptor);
+                m_TargetTextureOverride = new RenderTexture(width, height, 8, RenderTextureFormat.ARGB32, RenderTextureReadWrite.Linear);
 
             targetTexture.Create();
             targetTexture.name = "Labeling";

com.unity.perception/Runtime/GroundTruth/Resources/SemanticSegmentation.shader

@@ -2,7 +2,7 @@
 {
     Properties
     {
-        [PerObjectData] LabelingId("Labeling Id", Color) = (0,0,0,1)
+        [PerObjectData] LabelingId("Labeling Id", Vector) = (0,0,0,1)
     }
 
     HLSLINCLUDE

com.unity.perception/Runtime/GroundTruth/SemanticSegmentationCrossPipelinePass.cs

@@ -69,7 +69,7 @@ public override void SetupMaterialProperties(MaterialPropertyBlock mpb, Renderer
 
             //Set the labeling ID so that it can be accessed in ClassSemanticSegmentationPass.shader
             if (found)
-                mpb.SetColor(k_LabelingId, entry.color);
+                mpb.SetVector(k_LabelingId, entry.color);
         }
     }
 }

com.unity.perception/Tests/Runtime/GroundTruthTests/SegmentationGroundTruthTests.cs

@@ -44,7 +44,7 @@ void OnDestroy()
     [UnityPlatform(exclude = new[] {RuntimePlatform.LinuxEditor, RuntimePlatform.LinuxPlayer})]
     public class SegmentationPassTests : GroundTruthTestBase
     {
-        static readonly Color32 k_SemanticPixelValue = Color.blue;
+        static readonly Color32 k_SemanticPixelValue = new Color32(10, 20, 30, Byte.MaxValue);
 
         public enum SegmentationKind
         {
@@ -232,7 +232,7 @@ void OnSegmentationImageReceived<T>(int frameCount, NativeArray<T> data, RenderT
                 catch (Exception)
                 {
                     //uncomment to get RenderDoc captures while this check is failing
-                    //RenderDoc.EndCaptureRenderDoc(gameView);
+                    //UnityEditorInternal.RenderDoc.EndCaptureRenderDoc(gameView);
                     throw;
                 }
             }