Skip to content

Commit 8b82203

Browse files
authored
Toon EV adjustment help URL (#168)
* Fixed: * Dead links for Toon EV adjutment HELP URL Buttons. * Some classes are accessible from outside. * Fixed: typo in CHANGELOG.md [skip ci]
1 parent 36d0ae9 commit 8b82203

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

com.unity.toonshader/CHANGELOG.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Changelog
2-
## [0.7.2-preview] - 2022-05-27
3-
### Updated:
4-
* Next Version is 0.7.2-preview
2+
## [0.7.2-preview] - 2022-05-30
3+
### Fixed:
4+
* Dead links for Toon EV adjustment HELP URL Buttons.
5+
* Some classes are accessible from outside.
56

67
## [0.7.1-preview] - 2022-05-26
78
### Updated:

com.unity.toonshader/Editor/MeterialEditor/UTS3Documentation.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ namespace UnityEditor.Rendering.Toon
2323
/// </example>
2424
[Conditional("UNITY_EDITOR")]
2525
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Enum, AllowMultiple = false)]
26-
public class UTS3HelpURLAttribute : HelpURLAttribute
26+
internal class UTS3HelpURLAttribute : HelpURLAttribute
2727
{
2828
/// <summary>
2929
/// The constructor of the attribute
3030
/// </summary>
3131
/// <param name="pageName"></param>
3232
/// <param name="packageName"></param>
33-
public UTS3HelpURLAttribute(string pageName, string packageName = "com.unity.toonshader")
33+
internal UTS3HelpURLAttribute(string pageName, string packageName = "com.unity.toonshader")
3434
: base(UTS3DocumentationInfo.GetPageLink(packageName, pageName))
3535
{
3636
}
@@ -40,9 +40,9 @@ public UTS3HelpURLAttribute(string pageName, string packageName = "com.unity.too
4040
/// <summary>
4141
/// Documentation Info class.
4242
/// </summary>
43-
public class UTS3DocumentationInfo
43+
internal class UTS3DocumentationInfo
4444
{
45-
const string fallbackVersion = "0.7";
45+
internal const string fallbackVersion = "0.7";
4646
#if USE_GITHUB_DOC_LINK
4747
const string fallbackVersion = "";
4848
const string url = "https://github.com/Unity-Technologies/{0}/blob/development/v1/{0}/Documentation~/";
@@ -55,7 +55,7 @@ public class UTS3DocumentationInfo
5555
/// <summary>
5656
/// Current version of the documentation.
5757
/// </summary>
58-
public static string version
58+
internal static string version
5959
{
6060
get
6161
{
@@ -69,21 +69,21 @@ public static string version
6969
/// <param name="packageName">The package name</param>
7070
/// <param name="pageName">The page name</param>
7171
/// <returns>The full url page</returns>
72-
public static string GetPageLink(string packageName, string pageName) => string.Format(url, packageName, version, pageName);
72+
internal static string GetPageLink(string packageName, string pageName) => string.Format(url, packageName, version, pageName);
7373
}
7474

7575
/// <summary>
7676
/// Set of utils for documentation
7777
/// </summary>
78-
public static class UTS3DocumentationUtils
78+
internal static class UTS3DocumentationUtils
7979
{
8080
/// <summary>
8181
/// Obtains the help url from an enum
8282
/// </summary>
8383
/// <typeparam name="TEnum">The enum with a <see cref="HelpURLAttribute"/></typeparam>
8484
/// <param name="mask">[Optional] The current value of the enum</param>
8585
/// <returns>The full url</returns>
86-
public static string GetHelpURL<TEnum>(TEnum mask = default)
86+
internal static string GetHelpURL<TEnum>(TEnum mask = default)
8787
where TEnum : struct, IConvertible
8888
{
8989
var type = mask.GetType();

com.unity.toonshader/Runtime/ModelToonEvAdjustment.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Unity.Rendering.Toon
1313
{
14+
[HelpURL("https://docs.unity3d.com/Packages/[email protected]/manual/ToonEVAdjustment.html")]
1415
[ExecuteAlways]
1516
[DisallowMultipleComponent]
1617
internal class ModelToonEvAdjustment : MonoBehaviour

com.unity.toonshader/Runtime/SceneToonEvAdjustment.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@
99
using UnityObject = UnityEngine.Object;
1010
namespace Unity.Rendering.Toon
1111
{
12+
13+
1214
[ExecuteAlways]
1315
[DisallowMultipleComponent]
16+
[HelpURL("https://docs.unity3d.com/Packages/[email protected]/manual/ToonEVAdjustment.html")]
1417
internal class SceneToonEvAdjustment : MonoBehaviour
1518
{
1619
// flags

0 commit comments

Comments
 (0)