Skip to content

Commit 5dc92f1

Browse files
author
Chris Elion
authored
handle null action outputs (#2988)
1 parent b53b7ea commit 5dc92f1

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

ml-agents-envs/mlagents/envs/env_manager.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ class EnvironmentStep(NamedTuple):
1010
current_all_brain_info: AllBrainInfo
1111
brain_name_to_action_info: Optional[Dict[str, ActionInfo]]
1212

13+
def has_actions_for_brain(self, brain_name: str) -> bool:
14+
return (
15+
self.brain_name_to_action_info is not None
16+
and brain_name in self.brain_name_to_action_info
17+
and self.brain_name_to_action_info[brain_name].outputs is not None
18+
)
19+
1320

1421
class EnvManager(ABC):
1522
def __init__(self):

ml-agents/mlagents/trainers/trainer_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ def advance(self, env: EnvManager) -> int:
276276
for brain_name, trainer in self.trainers.items():
277277
if brain_name in self.trainer_metrics:
278278
self.trainer_metrics[brain_name].add_delta_step(delta_time_step)
279-
if brain_name in step_info.brain_name_to_action_info:
279+
if step_info.has_actions_for_brain(brain_name):
280280
trainer.add_experiences(
281281
step_info.previous_all_brain_info[brain_name],
282282
step_info.current_all_brain_info[brain_name],

0 commit comments

Comments
 (0)