Skip to content

Commit 6004556

Browse files
Upgrade ONNX to 1.15.0 (#6062)
This fixes builds of ONNX on OS X while installing ml-agents. OS X builds use Xcode by default, and the Xcode compiler defaults to using C++98 mode for C++ ( https://stackoverflow.com/a/21349148 ). This causes errors building protocol buffer libraries, which need to be compiled with support for C++14 or newer ( protocolbuffers/protobuf#12393 (comment) ). [This ONNX commit](onnx/onnx@a979e75) changes its compilation to use C++14 mode: releases that include this commit (1.15.0 or newer) build with Xcode by default. ONNX 1.15.0 uses a newer protocol buffer library, so allow newer versions here too.
1 parent 66f6b34 commit 6004556

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

com.unity.ml-agents/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ and this project adheres to
2727

2828
#### ml-agents / ml-agents-envs
2929
- Bumped numpy version to >=1.21.2,<1.24.0 (#5997)
30+
- Bumped onnx version to 1.15.0 (#6062)
31+
- Bumped protobuf version to >=3.6,<21 (#6062)
3032

3133
## [3.0.0-exp.1] - 2023-10-09
3234
### Major Changes

ml-agents-envs/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def run(self):
5656
"cloudpickle",
5757
"grpcio>=1.11.0,<=1.48.2",
5858
"Pillow>=4.2.1",
59-
"protobuf>=3.6,<3.20",
59+
"protobuf>=3.6,<3.21",
6060
"pyyaml>=3.1.0",
6161
"gym>=0.21.0",
6262
"pettingzoo==1.15.0",

ml-agents/setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def run(self):
6060
f"mlagents_envs=={VERSION}",
6161
"numpy>=1.21.2,<1.24.0",
6262
"Pillow>=4.2.1",
63-
"protobuf>=3.6,<3.20",
63+
"protobuf>=3.6,<3.21",
6464
"pyyaml>=3.1.0",
6565
"torch>=2.1.1",
6666
"tensorboard>=2.14",
@@ -72,7 +72,7 @@ def run(self):
7272
"attrs>=19.3.0",
7373
"huggingface_hub>=0.14",
7474
'pypiwin32==223;platform_system=="Windows"',
75-
"onnx==1.12.0",
75+
"onnx==1.15.0",
7676
],
7777
python_requires=">=3.10.1,<=3.10.12",
7878
entry_points={

0 commit comments

Comments
 (0)