You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your opinion matters a great deal to us. Only by hearing your thoughts on the Unity ML-Agents Toolkit can we continue to improve and grow. Please take a few minutes to let us know about it.
3
+
Your opinion matters a great deal to us. Only by hearing your thoughts on the
4
+
Unity ML-Agents Toolkit can we continue to improve and grow. Please take a few
5
+
minutes to let us know about it.
4
6
5
-
[Fill out the survey](https://goo.gl/forms/qFMYSYr5TlINvG6f1)
7
+
[Fill out the survey](https://goo.gl/forms/qFMYSYr5TlINvG6f1)
* Corresponding changes to documentation, unit tests and sample environments (if
32
+
When contributing to the project, please make sure that your Pull Request (PR)
33
+
contains the following:
34
+
35
+
- Detailed description of the changes performed
36
+
- Corresponding changes to documentation, unit tests and sample environments (if
34
37
applicable)
35
-
* Summary of the tests performed to validate your changes
36
-
* Issue numbers that the PR resolves (if any)
38
+
- Summary of the tests performed to validate your changes
39
+
- Issue numbers that the PR resolves (if any)
37
40
38
41
## Environments
39
42
40
43
We are also actively open to adding community contributed environments as
41
-
examples, as long as they are small, simple, demonstrate a unique feature of
42
-
the platform, and provide a unique non-trivial challenge to modern
43
-
machine learning algorithms. Feel free to submit these environments with a
44
-
PR explaining the nature of the environment and task.
44
+
examples, as long as they are small, simple, demonstrate a unique feature of the
45
+
platform, and provide a unique non-trivial challenge to modern machine learning
46
+
algorithms. Feel free to submit these environments with a PR explaining the
47
+
nature of the environment and task.
45
48
46
49
## Continuous Integration (CI)
47
50
48
51
We run CircleCI on all PRs; all tests must be passing before the PR is merged.
49
52
50
-
Several static checks are run on the codebase using the [pre-commit framework](https://pre-commit.com/) during CI. To execute the same checks locally, install `pre-commit` and run `pre-commit run --all-files`. Some hooks (for example, `black`) will output the corrected version of the code; others (like `mypy`) may require more effort to fix.
53
+
Several static checks are run on the codebase using the
54
+
[pre-commit framework](https://pre-commit.com/) during CI. To execute the same
55
+
checks locally, install `pre-commit` and run `pre-commit run --all-files`. Some
56
+
hooks (for example, `black`) will output the corrected version of the code;
57
+
others (like `mypy`) may require more effort to fix.
51
58
52
59
### Code style
53
-
All python code should be formatted with [`black`](https://github.com/ambv/black). Style and formatting for C# may be enforced later.
60
+
61
+
All python code should be formatted with
62
+
[`black`](https://github.com/ambv/black). Style and formatting for C# may be
63
+
enforced later.
54
64
55
65
### Python type annotations
56
-
We use [`mypy`](http://mypy-lang.org/) to perform static type checking on python code. Currently not all code is annotated but we will increase coverage over time. If you are adding or refactoring code, please
66
+
67
+
We use [`mypy`](http://mypy-lang.org/) to perform static type checking on python
68
+
code. Currently not all code is annotated but we will increase coverage over
69
+
time. If you are adding or refactoring code, please
70
+
57
71
1. Add type annotations to the new or refactored code.
58
-
2. Make sure that code calling or called by the modified code also has type annotations.
72
+
2. Make sure that code calling or called by the modified code also has type
73
+
annotations.
59
74
60
-
The [type hint cheat sheet](https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html) provides a good introduction to adding type hints.
75
+
The
76
+
[type hint cheat sheet](https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html)
77
+
provides a good introduction to adding type hints.
61
78
62
79
## Contributor License Agreements
63
80
64
-
When you open a pull request, you will be asked to acknolwedge our Contributor License Agreement. We allow both individual contributions and contributions made on behalf of companies. We use an open source tool called CLA assistant. If you have any questions on our CLA, please [submit an issue](https://github.com/Unity-Technologies/ml-agents/issues) or email us at [email protected].
81
+
When you open a pull request, you will be asked to acknolwedge our Contributor
82
+
License Agreement. We allow both individual contributions and contributions made
83
+
on behalf of companies. We use an open source tool called CLA assistant. If you
84
+
have any questions on our CLA, please
85
+
[submit an issue](https://github.com/Unity-Technologies/ml-agents/issues) or
0 commit comments