Skip to content

Commit b31ba96

Browse files
author
Marwan Mattar
authored
Release 1 mm formatting (#3904)
* Formatting lines. * Fix changelogs
1 parent ab0962e commit b31ba96

File tree

8 files changed

+326
-259
lines changed

8 files changed

+326
-259
lines changed

SURVEY.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Unity ML-Agents Toolkit Survey
22

3-
Your opinion matters a great deal to us. Only by hearing your thoughts on the Unity ML-Agents Toolkit can we continue to improve and grow. Please take a few minutes to let us know about it.
3+
Your opinion matters a great deal to us. Only by hearing your thoughts on the
4+
Unity ML-Agents Toolkit can we continue to improve and grow. Please take a few
5+
minutes to let us know about it.
46

5-
[Fill out the survey](https://goo.gl/forms/qFMYSYr5TlINvG6f1)
7+
[Fill out the survey](https://goo.gl/forms/qFMYSYr5TlINvG6f1)

com.unity.ml-agents/CHANGELOG.md

Lines changed: 48 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ and this project adheres to
99
## [1.0.0-preview] - 2020-05-06
1010

1111
### Major Changes
12+
1213
#### com.unity.ml-agents (C#)
14+
1315
- The `MLAgents` C# namespace was renamed to `Unity.MLAgents`, and other nested
1416
namespaces were similarly renamed. (#3843)
1517
- The offset logic was removed from DecisionRequester. (#3716)
@@ -23,26 +25,32 @@ and this project adheres to
2325
`AgentAction` and `AgentReset` have been removed. (#3770)
2426
- The SideChannel API has changed (#3833, #3660) :
2527
- Introduced the `SideChannelManager` to register, unregister and access side
26-
channels.
28+
channels.
2729
- `Academy.FloatProperties` was replaced by `Academy.EnvironmentParameters`.
28-
See the [Migration Guide](../docs/Migrating.md) for more details on upgrading.
30+
See the [Migration Guide](../docs/Migrating.md) for more details on
31+
upgrading.
2932
- `SideChannel.OnMessageReceived` is now a protected method (was public)
3033
- SideChannel IncomingMessages methods now take an optional default argument,
31-
which is used when trying to read more data than the message contains.
34+
which is used when trying to read more data than the message contains.
3235
- Added a feature to allow sending stats from C# environments to TensorBoard
33-
(and other python StatsWriters). To do this from your code, use
34-
`Academy.Instance.StatsRecorder.Add(key, value)`. (#3660)
35-
- `CameraSensorComponent.m_Grayscale` and `RenderTextureSensorComponent.m_Grayscale`
36-
were changed from `public` to `private`. These can still be accessed via their
37-
corresponding properties. (#3808)
36+
(and other python StatsWriters). To do this from your code, use
37+
`Academy.Instance.StatsRecorder.Add(key, value)`. (#3660)
38+
- `CameraSensorComponent.m_Grayscale` and
39+
`RenderTextureSensorComponent.m_Grayscale` were changed from `public` to
40+
`private`. These can still be accessed via their corresponding properties.
41+
(#3808)
3842
- Public fields and properties on several classes were renamed to follow Unity's
3943
C# style conventions. All public fields and properties now use "PascalCase"
4044
instead of "camelCase"; for example, `Agent.maxStep` was renamed to
4145
`Agent.MaxStep`. For a full list of changes, see the pull request. (#3828)
42-
- `WriteAdapter` was renamed to `ObservationWriter`. If you have a custom `ISensor` implementation,
43-
you will need to change the signature of its `Write()` method. (#3834)
44-
- Updated to Barracuda 0.7.0-preivew which has breaking namespace and assembly name changes. (#3875)
46+
- `WriteAdapter` was renamed to `ObservationWriter`. If you have a custom
47+
`ISensor` implementation, you will need to change the signature of its
48+
`Write()` method. (#3834)
49+
- Updated to Barracuda 0.7.0-preivew which has breaking namespace and assembly
50+
name changes. (#3875)
51+
4552
#### ml-agents / ml-agents-envs / gym-unity (Python)
53+
4654
- The `--load` and `--train` command-line flags have been deprecated. Training
4755
now happens by default, and use `--resume` to resume training instead. (#3705)
4856
- The Jupyter notebooks have been removed from the repository. (#3704)
@@ -57,26 +65,32 @@ and this project adheres to
5765
- The GhostTrainer has been extended to support asymmetric games and the
5866
asymmetric example environment Strikers Vs. Goalie has been added. (#3653)
5967
- The `UnityEnv` class from the `gym-unity` package was renamed
60-
`UnityToGymWrapper` and no longer creates the `UnityEnvironment`.
61-
Instead, the `UnityEnvironment` must be passed as input to the
62-
constructor of `UnityToGymWrapper` (#3812)
68+
`UnityToGymWrapper` and no longer creates the `UnityEnvironment`. Instead, the
69+
`UnityEnvironment` must be passed as input to the constructor of
70+
`UnityToGymWrapper` (#3812)
6371

6472
### Minor Changes
6573

6674
#### com.unity.ml-agents (C#)
75+
6776
- Added new 3-joint Worm ragdoll environment. (#3798)
6877
- `StackingSensor` was changed from `internal` visibility to `public`. (#3701)
6978
- The internal event `Academy.AgentSetStatus` was renamed to
7079
`Academy.AgentPreStep` and made public. (#3716)
7180
- Academy.InferenceSeed property was added. This is used to initialize the
72-
random number generator in ModelRunner, and is incremented for each ModelRunner. (#3823)
73-
- Added `Agent.GetObservations(), which returns a read-only view of the observations
74-
added in `CollectObservations()`. (#3825)
75-
- `UnityRLCapabilities` was added to help inform users when RL features are mismatched between C# and Python packages. (#3831)
81+
random number generator in ModelRunner, and is incremented for each
82+
ModelRunner. (#3823)
83+
- Added `Agent.GetObservations()`, which returns a read-only view of the
84+
observations added in `CollectObservations()`. (#3825)
85+
- `UnityRLCapabilities` was added to help inform users when RL features are
86+
mismatched between C# and Python packages. (#3831)
87+
7688
#### ml-agents / ml-agents-envs / gym-unity (Python)
89+
7790
- Format of console output has changed slightly and now matches the name of the
7891
model/summary directory. (#3630, #3616)
79-
- Renamed 'Generalization' feature to 'Environment Parameter Randomization'. (#3646)
92+
- Renamed 'Generalization' feature to 'Environment Parameter Randomization'.
93+
(#3646)
8094
- Timer files now contain a dictionary of metadata, including things like the
8195
package version numbers. (#3758)
8296
- The way that UnityEnvironment decides the port was changed. If no port is
@@ -85,23 +99,30 @@ and this project adheres to
8599
environment port) will be used. (#3673)
86100
- Running `mlagents-learn` with the same `--run-id` twice will no longer
87101
overwrite the existing files. (#3705)
88-
- Model updates can now happen asynchronously with environment steps for better performance. (#3690)
89-
- `num_updates` and `train_interval` for SAC were replaced with `steps_per_update`. (#3690)
90-
- The maximum compatible version of tensorflow was changed to allow tensorflow 2.1 and 2.2. This
91-
will allow use with python 3.8 using tensorflow 2.2.0rc3. (#3830)
92-
- `mlagents-learn` will no longer set the width and height of the executable window to 84x84
93-
when no width nor height arguments are given. (#3867)
102+
- Model updates can now happen asynchronously with environment steps for better
103+
performance. (#3690)
104+
- `num_updates` and `train_interval` for SAC were replaced with
105+
`steps_per_update`. (#3690)
106+
- The maximum compatible version of tensorflow was changed to allow tensorflow
107+
2.1 and 2.2. This will allow use with python 3.8 using tensorflow 2.2.0rc3.
108+
(#3830)
109+
- `mlagents-learn` will no longer set the width and height of the executable
110+
window to 84x84 when no width nor height arguments are given. (#3867)
94111

95112
### Bug Fixes
96113

97114
#### com.unity.ml-agents (C#)
115+
98116
- Fixed a display bug when viewing Demonstration files in the inspector. The
99117
shapes of the observations in the file now display correctly. (#3771)
118+
100119
#### ml-agents / ml-agents-envs / gym-unity (Python)
120+
101121
- Fixed an issue where exceptions from environments provided a returncode of 0.
102122
(#3680)
103-
- Self-Play team changes will now trigger a full environment reset. This prevents trajectories
104-
in progress during a team change from getting into the buffer. (#3870)
123+
- Self-Play team changes will now trigger a full environment reset. This
124+
prevents trajectories in progress during a team change from getting into the
125+
buffer. (#3870)
105126

106127
## [0.15.1-preview] - 2020-03-30
107128

com.unity.ml-agents/CONTRIBUTING.md

Lines changed: 49 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,58 +7,80 @@ of guidelines to ensure that your extensions can be easily integrated.
77

88
## Communication
99

10-
First, please read through our [code of conduct](https://github.com/Unity-Technologies/ml-agents/blob/master/CODE_OF_CONDUCT.md), as we
11-
expect all our contributors to follow it.
10+
First, please read through our
11+
[code of conduct](https://github.com/Unity-Technologies/ml-agents/blob/master/CODE_OF_CONDUCT.md),
12+
as we expect all our contributors to follow it.
1213

1314
Second, before starting on a project that you intend to contribute to the
1415
ML-Agents Toolkit (whether environments or modifications to the codebase), we
1516
**strongly** recommend posting on our
16-
[Issues page](https://github.com/Unity-Technologies/ml-agents/issues)
17-
and briefly outlining the changes you plan to make. This will enable us to
18-
provide some context that may be helpful for you. This could range from advice
19-
and feedback on how to optimally perform your changes or reasons for not doing
20-
it.
17+
[Issues page](https://github.com/Unity-Technologies/ml-agents/issues) and
18+
briefly outlining the changes you plan to make. This will enable us to provide
19+
some context that may be helpful for you. This could range from advice and
20+
feedback on how to optimally perform your changes or reasons for not doing it.
2121

22-
Lastly, if you're looking for input on what to contribute, feel free to
23-
reach out to us directly at [email protected] and/or browse the GitHub
24-
issues with the `contributions welcome` label.
22+
Lastly, if you're looking for input on what to contribute, feel free to reach
23+
out to us directly at [email protected] and/or browse the GitHub issues with
24+
the `contributions welcome` label.
2525

2626
## Git Branches
27-
The master branch corresponds to the most recent version of the project.
28-
Note that this may be newer that the [latest release](https://github.com/Unity-Technologies/ml-agents/releases/tag/latest_release).
2927

30-
When contributing to the project, please make sure that your Pull Request (PR) contains the following:
28+
The master branch corresponds to the most recent version of the project. Note
29+
that this may be newer that the
30+
[latest release](https://github.com/Unity-Technologies/ml-agents/releases/tag/latest_release).
3131

32-
* Detailed description of the changes performed
33-
* Corresponding changes to documentation, unit tests and sample environments (if
32+
When contributing to the project, please make sure that your Pull Request (PR)
33+
contains the following:
34+
35+
- Detailed description of the changes performed
36+
- Corresponding changes to documentation, unit tests and sample environments (if
3437
applicable)
35-
* Summary of the tests performed to validate your changes
36-
* Issue numbers that the PR resolves (if any)
38+
- Summary of the tests performed to validate your changes
39+
- Issue numbers that the PR resolves (if any)
3740

3841
## Environments
3942

4043
We are also actively open to adding community contributed environments as
41-
examples, as long as they are small, simple, demonstrate a unique feature of
42-
the platform, and provide a unique non-trivial challenge to modern
43-
machine learning algorithms. Feel free to submit these environments with a
44-
PR explaining the nature of the environment and task.
44+
examples, as long as they are small, simple, demonstrate a unique feature of the
45+
platform, and provide a unique non-trivial challenge to modern machine learning
46+
algorithms. Feel free to submit these environments with a PR explaining the
47+
nature of the environment and task.
4548

4649
## Continuous Integration (CI)
4750

4851
We run CircleCI on all PRs; all tests must be passing before the PR is merged.
4952

50-
Several static checks are run on the codebase using the [pre-commit framework](https://pre-commit.com/) during CI. To execute the same checks locally, install `pre-commit` and run `pre-commit run --all-files`. Some hooks (for example, `black`) will output the corrected version of the code; others (like `mypy`) may require more effort to fix.
53+
Several static checks are run on the codebase using the
54+
[pre-commit framework](https://pre-commit.com/) during CI. To execute the same
55+
checks locally, install `pre-commit` and run `pre-commit run --all-files`. Some
56+
hooks (for example, `black`) will output the corrected version of the code;
57+
others (like `mypy`) may require more effort to fix.
5158

5259
### Code style
53-
All python code should be formatted with [`black`](https://github.com/ambv/black). Style and formatting for C# may be enforced later.
60+
61+
All python code should be formatted with
62+
[`black`](https://github.com/ambv/black). Style and formatting for C# may be
63+
enforced later.
5464

5565
### Python type annotations
56-
We use [`mypy`](http://mypy-lang.org/) to perform static type checking on python code. Currently not all code is annotated but we will increase coverage over time. If you are adding or refactoring code, please
66+
67+
We use [`mypy`](http://mypy-lang.org/) to perform static type checking on python
68+
code. Currently not all code is annotated but we will increase coverage over
69+
time. If you are adding or refactoring code, please
70+
5771
1. Add type annotations to the new or refactored code.
58-
2. Make sure that code calling or called by the modified code also has type annotations.
72+
2. Make sure that code calling or called by the modified code also has type
73+
annotations.
5974

60-
The [type hint cheat sheet](https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html) provides a good introduction to adding type hints.
75+
The
76+
[type hint cheat sheet](https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html)
77+
provides a good introduction to adding type hints.
6178

6279
## Contributor License Agreements
6380

64-
When you open a pull request, you will be asked to acknolwedge our Contributor License Agreement. We allow both individual contributions and contributions made on behalf of companies. We use an open source tool called CLA assistant. If you have any questions on our CLA, please [submit an issue](https://github.com/Unity-Technologies/ml-agents/issues) or email us at [email protected].
81+
When you open a pull request, you will be asked to acknolwedge our Contributor
82+
License Agreement. We allow both individual contributions and contributions made
83+
on behalf of companies. We use an open source tool called CLA assistant. If you
84+
have any questions on our CLA, please
85+
[submit an issue](https://github.com/Unity-Technologies/ml-agents/issues) or
86+
email us at [email protected].

docs/API-Reference.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
Our developer-facing C# classes have been documented to be compatible with
44
Doxygen for auto-generating HTML documentation.
55

6-
To generate the API reference, download Doxygen
7-
and run the following command within the `docs/` directory:
6+
To generate the API reference, download Doxygen and run the following command
7+
within the `docs/` directory:
88

99
```sh
1010
doxygen dox-ml-agents.conf

docs/Migrating.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ double-check that the versions are in the same. The versions can be found in
4343
source of error where users would return arrays of the wrong size.
4444
- The SideChannel API has changed (#3833, #3660) :
4545
- Introduced the `SideChannelManager` to register, unregister and access side
46-
channels.
47-
- `EnvironmentParameters` replaces the default `FloatProperties`.
48-
You can access the `EnvironmentParameters` with
49-
`Academy.Instance.EnvironmentParameters` on C#. If you were previously creating
50-
a `UnityEnvironment` in python and passing it a `FloatPropertiesChannel`,
51-
create an `EnvironmentParametersChannel` instead.
46+
channels.
47+
- `EnvironmentParameters` replaces the default `FloatProperties`. You can
48+
access the `EnvironmentParameters` with
49+
`Academy.Instance.EnvironmentParameters` on C#. If you were previously
50+
creating a `UnityEnvironment` in python and passing it a
51+
`FloatPropertiesChannel`, create an `EnvironmentParametersChannel` instead.
5252
- `SideChannel.OnMessageReceived` is now a protected method (was public)
5353
- SideChannel IncomingMessages methods now take an optional default argument,
5454
which is used when trying to read more data than the message contains.

0 commit comments

Comments
 (0)