Skip to content

Commit d2ceb9f

Browse files
author
Chris Elion
authored
fix BananaIL scene (#2512)
* add reset parameters to scene * default values for BananaAgent reset parameters
1 parent 7ddb0f1 commit d2ceb9f

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

UnitySDK/Assets/ML-Agents/Examples/BananaCollectors/Scenes/BananaIL.unity

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,11 @@ MonoBehaviour:
719719
timeScale: 1
720720
targetFrameRate: 60
721721
resetParameters:
722-
resetParameters: []
722+
resetParameters:
723+
- key: laser_length
724+
value: 1
725+
- key: agent_scale
726+
value: 1
723727
agents: []
724728
listArea: []
725729
totalScore: 0

UnitySDK/Assets/ML-Agents/Examples/BananaCollectors/Scripts/BananaAgent.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class BananaAgent : Agent
3030
public bool contribute;
3131
private RayPerception3D rayPer;
3232
public bool useVectorObs;
33-
33+
3434

3535
public override void InitializeAgent()
3636
{
@@ -106,7 +106,7 @@ public void MoveAgent(float[] act)
106106
var rightAxis = (int)act[1];
107107
var rotateAxis = (int)act[2];
108108
var shootAxis = (int)act[3];
109-
109+
110110
switch (forwardAxis)
111111
{
112112
case 1:
@@ -116,7 +116,7 @@ public void MoveAgent(float[] act)
116116
dirToGo = -transform.forward;
117117
break;
118118
}
119-
119+
120120
switch (rightAxis)
121121
{
122122
case 1:
@@ -134,7 +134,7 @@ public void MoveAgent(float[] act)
134134
break;
135135
case 2:
136136
rotateDir = transform.up;
137-
break;
137+
break;
138138
}
139139
switch (shootAxis)
140140
{
@@ -279,15 +279,16 @@ public override void AgentOnDone()
279279

280280
public void SetLaserLengths()
281281
{
282-
laser_length = myAcademy.resetParameters["laser_length"];
282+
laser_length = myAcademy.resetParameters.TryGetValue("laser_length", out laser_length) ? laser_length: 1.0f;
283283
}
284284

285285
public void SetAgentScale()
286286
{
287-
var agent_scale = myAcademy.resetParameters["agent_scale"];
288-
gameObject.transform.localScale = new Vector3(agent_scale, agent_scale, agent_scale);
287+
float agentScale;
288+
agentScale = myAcademy.resetParameters.TryGetValue("agent_scale", out agentScale) ? agentScale : 1.0f;
289+
gameObject.transform.localScale = new Vector3(agentScale, agentScale, agentScale);
289290
}
290-
291+
291292
public void SetResetParameters()
292293
{
293294
SetLaserLengths();

0 commit comments

Comments
 (0)