Skip to content

Commit 633e9c1

Browse files
committed
Fixes for HttpUtility.UrlEncode for Unity aot and jit profiles
Reverting HttpUtility.UrlEncode back to the System.dll to keep netstandard profiles smaller, especially on Android. In Unity integration testing we found that adding System.Web to netstandard profile brings in 4 dlls to Android APKs that were not there before. This attempt is to leave HttpUtility in System.dll and use a type forward in System.Web to satisfy .net 4 profile references.
1 parent c42cbfa commit 633e9c1

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

mcs/class/Facades/netstandard/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ LIB_REFS += System.Transactions System.Runtime.Serialization System.Data System.
2626
else ifeq ($(PROFILE),xammac_net_4_5)
2727
LIB_REFS += System.Web.Services System.Transactions System.Runtime.Serialization System.Data System.Data.DataSetExtensions
2828
else ifeq (2.1, $(FRAMEWORK_VERSION))
29-
ifeq ($(PROFILE),unityaot)
30-
LIB_REFS += System.Web
31-
else
29+
ifneq ($(PROFILE),unityaot)
3230
LIB_REFS += System.Web.Services System.Transactions System.Runtime.Serialization System.Data System.Data.DataSetExtensions
3331
endif
3432
LIB_REFS += System.Transactions System.Runtime.Serialization System.Data System.Data.DataSetExtensions

mcs/class/System.Web/Assembly/AssemblyInfo.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,4 +138,9 @@
138138
[assembly: WebResource ("GridView.js", "text/javascript")]
139139
[assembly: WebResource ("webform.js", "text/javascript")]
140140
[assembly: WebResource ("WebUIValidation_2.0.js", "text/javascript")]
141+
#endif
142+
143+
#if UNITY_AOT && FULL_AOT_RUNTIME
144+
[assembly: TypeForwardedTo (typeof (System.Web.HttpUtility))]
145+
[assembly: TypeForwardedTo (typeof (System.Web.Util.HttpEncoder))]
141146
#endif

mcs/class/System.Web/unityaot_System.Web.dll.sources

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,4 @@ Assembly/AssemblyInfo.cs
22
../../build/common/Consts.cs
33
../../build/common/Locale.cs
44
../../build/common/MonoTODOAttribute.cs
5-
../System/System/MonoToolsLocator.cs
6-
7-
System.Web/HttpUtility.cs
8-
System.Web.Util/Helpers.cs
9-
System.Web.Util/HttpEncoder.cs
5+
../System/System/MonoToolsLocator.cs
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#include mobile_System.dll.sources
2-
2+
../System.Web/System.Web/HttpUtility.cs
3+
../System.Web/System.Web.Util/Helpers.cs
4+
../System.Web/System.Web.Util/HttpEncoder.cs
35
System.CodeDom/CodeCompileUnit.cs
46
System.CodeDom/CodeTypeDeclaration.cs
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#include mobile_System.dll.sources
2-
2+
../System.Web/System.Web/HttpUtility.cs
3+
../System.Web/System.Web.Util/Helpers.cs
4+
../System.Web/System.Web.Util/HttpEncoder.cs
35
System.CodeDom/CodeCompileUnit.cs
46
System.CodeDom/CodeTypeDeclaration.cs

mcs/class/System/win32_unityaot_System.dll.sources

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
#include mobile_System.dll.sources
22
#include corefx.windows.sources
3+
../System.Web/System.Web/HttpUtility.cs
4+
../System.Web/System.Web.Util/Helpers.cs
5+
../System.Web/System.Web.Util/HttpEncoder.cs
36

47
System.Net.NetworkInformation/Win32UnixFactoryPal.cs
58

0 commit comments

Comments
 (0)