Fix issue where TLS requests would reallocate a buffer when it could reuse it

Michael DeRoy · Michael DeRoy · commit b50448047fd5 · 2019-02-12T15:04:08.000-05:00
diff --git a/mcs/class/System/Mono.Net.Security/AsyncProtocolRequest.cs b/mcs/class/System/Mono.Net.Security/AsyncProtocolRequest.cs
@@ -70,7 +70,10 @@ public void Reset ()
 		{
 			Offset = Size = 0;
 			TotalBytes = 0;
-			Buffer = new byte[InitialSize];
+			if (Buffer.Length <= InitialSize)
+			    Array.Clear (Buffer, 0, Buffer.Length);
+			else
+			    Buffer = new byte[InitialSize];
 			Complete = false;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,10 @@ public void Reset ()`
`70`	`70`	`{`
`71`	`71`	`Offset = Size = 0;`
`72`	`72`	`TotalBytes = 0;`
`73`		`- Buffer = new byte[InitialSize];`
	`73`	`+ if (Buffer.Length <= InitialSize)`
	`74`	`+ Array.Clear (Buffer, 0, Buffer.Length);`
	`75`	`+ else`
	`76`	`+ Buffer = new byte[InitialSize];`
`74`	`77`	`Complete = false;`
`75`	`78`	`}`
`76`	`79`