-
Notifications
You must be signed in to change notification settings - Fork 11
add button to clear all messages #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a "Clear All Messages" button that allows users to dismiss all displayed messages at once when there are 3 or more messages present.
Key changes:
- Refactored inline onclick handlers to event delegation pattern using jQuery
- Added a clear all button that triggers individual message deletions
- Updated CSS to use flexbox layout for message container
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webroot/js/messages.js | New JavaScript file implementing event handlers for individual and bulk message deletion |
| webroot/css/messages.css | Updated styling to support flexbox layout and position the clear all button, removed problematic width calculation |
| resources/templates/header.php | Refactored message buttons to use data attributes instead of inline JavaScript, added conditional clear all button |
| resources/templates/footer.php | Added messages.js to the list of loaded scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
closes #406 |
Screen.Recording.2025-12-19.at.10.03.53.AM.mov
Screen.Recording.2025-12-19.at.10.11.33.AM.mov
if
message_delete.phphas uncaught exception:Screen.Recording.2025-12-19.at.11.49.01.AM.mov