Skip to content

Conversation

@simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Dec 23, 2025

Closes #382

  • bug 1: filter.js, sort.js are loaded on all pages, but they assume that a table will always exist
  • bug 2: in remove cache from big pages #266 I added a nested table for user groups in user-mgmt.php, but did not update the query selector for table rows to exclude the nested table rows
    • this is done by querying :scope > tr on the <tbody> element
  • bug 3: in use <th> instead of <tr class='key'> #437 I replaced <tr class='key'> with <th>, but did not update the query selector lines to look for the new element type
  • also wrapped stuff in an immediately invoked function expression IIFE to avoid future variable name conflicts

@simonLeary42 simonLeary42 marked this pull request as ready for review December 23, 2025 14:10
@simonLeary42 simonLeary42 requested a review from Copilot December 23, 2025 14:10

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simonLeary42 simonLeary42 mentioned this pull request Dec 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@simonLeary42 simonLeary42 merged commit a22ad67 into main Dec 23, 2025
6 checks passed
@simonLeary42 simonLeary42 deleted the js-fix branch December 23, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS console errors

2 participants