refactor scripts #468
Merged
refactor scripts #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors script handling to improve clarity and consistency by removing version numbers from NPM-copied filenames, changing the cache-busting query parameter to avoid confusion between library versions and application versions, and consolidating script loading.
- Removed version numbers from jQuery and CKEditor filenames to avoid confusion with the application version
- Changed cache-busting parameter from
?v=to?cache_bust_increment_me=for better semantic clarity - Attempted to consolidate script loading by moving modal.js to the footer
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates NPM file copy destinations to remove version numbers from jQuery and CKEditor filenames |
| resources/templates/header.php | Refactors script and CSS loading into loops, removes integrity checks, updates cache-busting parameter, and removes modal.js from early script loading |
| resources/templates/footer.php | Adds modal.js to footer script loading and updates cache-busting parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?v=....to?cache_bust_increment_me=...jquery.min.js?v=1.5.1when1.5.1is not the jquery version but the account portal version