add more page loading tests #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for non-admin users attempting to access admin pages. The implementation modifies error handling methods to accept user-facing messages and updates the test framework to capture and verify page output.
Key changes:
- Enhanced
UnityHTTPDerror methods (badRequest,forbidden,internalServerError) to accept optional user messages - Modified test helper function
http_getto return output for verification - Added test cases verifying non-admin users receive appropriate error messages when accessing admin pages
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/lib/UnityHTTPD.php | Added optional user_message parameter to error methods and simplified die() method |
| webroot/admin/user-mgmt.php | Updated forbidden() call to include user-facing error message |
| webroot/admin/pi-mgmt.php | Updated forbidden() call to include user-facing error message |
| webroot/admin/notices.php | Updated forbidden() call to include user-facing error message |
| webroot/admin/content.php | Updated forbidden() call to include user-facing error message |
| webroot/admin/ajax/get_page_contents.php | Updated forbidden() call to include user-facing error message |
| webroot/admin/ajax/get_group_members.php | Updated forbidden() call to include user-facing error message |
| test/phpunit-bootstrap.php | Changed http_get return type from void to string to capture output |
| test/functional/PageLoadTest.php | Enhanced tests to verify page content with regex matching and added non-admin access test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonLeary42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.