Skip to content

write tests for session cleanup #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonLeary42 merged 1 commit into from
Jan 16, 2026
Merged

write tests for session cleanup #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions test/functional/SessionCleanupTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

class SessionCleanupTest extends UnityWebPortalTestCase
{
public function testSessionCleanup()
{
global $_SESSION;
$this->switchUser("Normal");
$first_session_id = session_id();
$_SESSION["csrf_tokens"] = ["foobar"];
// set last login timestamp to 1970-00-00 00:00
// assume duration from epoch until now is greater than config session_cleanup_idle_seconds
$_SESSION["LAST_ACTIVITY"] = 0;
$this->switchUser("Normal");
$this->assertEquals($first_session_id, session_id());
$this->assertEmpty($_SESSION["csrf_tokens"]);
}

public function testSessionNotCleanedUp()
{
global $_SESSION;
$this->switchUser("Normal");
$first_session_id = session_id();
$_SESSION["csrf_tokens"] = ["foobar"];
// set last login timestamp to a future timestamp
// assume negative time delta is less than config session_cleanup_idle_seconds
$_SESSION["LAST_ACTIVITY"] = time() + 999;
$this->switchUser("Normal");
$this->assertEquals($first_session_id, session_id());
$this->assertEqualsCanonicalizing(["foobar"], $_SESSION["csrf_tokens"]);
}
}
9 changes: 5 additions & 4 deletions test/phpunit-bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ class UnityWebPortalTestCase extends TestCase
{
private ?string $last_user_nickname = null;
private ?string $current_user_nickname = null;
private array $uid_to_latest_session_id = [];
private array $nickname_to_latest_session_id = [];
// FIXME these names are wrong
private static array $UID2ATTRIBUTES = [
"user1_org1_test" => ["user1@org1.test", "foo", "bar", "user1@org1.test"],
Expand Down Expand Up @@ -529,12 +529,13 @@ function switchUser(
if (session_status() === PHP_SESSION_ACTIVE) {
session_write_close();
}
if (!$reuse_last_session || !array_key_exists($nickname, $this->uid_to_latest_session_id)) {
$previous_session_id = $this->nickname_to_latest_session_id[$nickname] ?? null;
if (!$reuse_last_session || !$previous_session_id) {
$session_id = str_replace(["_", "@", "."], "-", uniqid($eppn . "_"));
$this->uid_to_latest_session_id[$uid] = $session_id;
$this->nickname_to_latest_session_id[$nickname] = $session_id;
session_id($session_id);
} else {
session_id($this->uid_to_latest_session_id[$uid]);
session_id($previous_session_id);
}
$this->last_user_nickname = $this->current_user_nickname;
$this->current_user_nickname = $nickname;
Expand Down