Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 8b797d7.
bryank-cs
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clone of #520 which I accidentally broke
Closes #392
Puts back the old "disband PI" functionality (removed in #207) using the term "disable" instead of "disband". A PI group can now have the isDisabled attribute set to "TRUE" and it will be ignored by the portal. If a PI is once again approved for a PI group, the old group will have isDisabled set to "FALSE" or unset.
Note: Disabled PI groups should have no members.
Note: I used OIDs 1.1.1 and 1.1.2 for my new LDAP stuff. 1.1 is documented as a "dead namespace" in OID land and is advisable for "private experiments". copilot doesn't like that I did this.
Note: if a large PI group is disabled by an admin, while updating the qualified status of each member, the portal will query for the members' attributes one-at-a-time and then do $user->getPIGroupGIDs() one-at-a-time, which is a lot of LDAP queries. I implemented an optimized version of this, but it's very ugly.
Test cases added:
Screen.Recording.2026-01-22.at.10.59.48.AM.mov