send emails to managers as well as group owners #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates group email notifications so that both group owners and group managers receive key lifecycle emails (creation, approval/denial, membership changes, etc.).
Changes:
- Updated all relevant
UnityGroupmethods to send notification emails to the owner and all managers using a new helper,getOwnerAndManagerMails(). - Adjusted the context data for PI group request handling to include owner/manager emails and reused the new helper in multiple notification flows.
- Added a private utility method in
UnityGroupto collect, deduplicate, and sort the owner’s and managers’ email addresses.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonLeary42
force-pushed
the
mail-managers
branch
from
effd5f3 to
31f7519
Compare
simonLeary42
force-pushed
the
mail-managers
branch
from
d956985 to
5326a0f
Compare
simonLeary42
force-pushed
the
mail-managers
branch
from
ba03b54 to
89a138c
Compare
simonLeary42
force-pushed
the
mail-managers
branch
from
89a138c to
d677868
Compare
simonLeary42
force-pushed
the
mail-managers
branch
from
72ab130 to
81cd2fd
Compare
bryank-cs
reviewed
Jan 28, 2026
bryank-cs
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same plus addressing scheme as
unity-course.php, so the owner mail for a course group is identical to one of the manager mails.The current addressing scheme omits the organization, so name conflicts are possible though unlikely. For courses this is fine, but if we start letting normal PI groups have managers, name conflicts will become more likely. If someday we update PI groups so that one user can own multiple groups, we will have to solve this problem.