Skip to content

Commit dac93a2

Browse files
author
Benjamin Pachev
committed
Merge branch 'main' into feature/documentation-updates
2 parents 53162f8 + 4e45a93 commit dac93a2

33 files changed

+6872
-1198
lines changed

dev-requirements.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
-r requirements.txt
21
ruff
32
pytest
43
pytest-env
@@ -12,4 +11,4 @@ coverage
1211
types-seaborn
1312
nbconvert
1413
nbdime
15-
types-requests
14+
types-requests

docs/preprocess.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@
44
### Attributes Omitted
55
- **UUID**
66
- **Nodes**: NodesList have more specific information
7-
- **Preempted**: Status have more valid information
7+
- **Preempted**: Contains unreliable data. Use Status column instead (PREEMPT for
8+
unfinished, COMPLETE/FAILED/etc. for finished preempted jobs).
89
- **EndTime**: Can be calculated from StartTime and Elapsed
910

1011
### Options for Including or Omitting Jobs
1112
- **Keeping CPU jobs:**
1213
- If `GPUType` is null, the value will be filled with `["cpu"]`
1314
- If `GPUs` is null or is 0, the value will be 0.
1415
- **Keeping jobs where the status is "Failed" or "Cancelled"**
16+
- **Keeping jobs where the QOS is customized (not normal, long, or short)**
1517

1618
### Records Omitted If:
1719
- `Elapsed` is less than the minimum threshold

notebooks/Efficiency Analysis.ipynb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
"\n",
9797
"from src.analysis import efficiency_analysis as ea\n",
9898
"from src.visualization import JobsWithMetricsVisualizer, UsersWithMetricsVisualizer\n",
99+
"from src.utilities import load_and_preprocess_jobs\n",
99100
"\n",
100101
"# Automatically reload modules before executing code\n",
101102
"# This is useful for development to see changes without restarting the kernel.\n",
@@ -112,7 +113,7 @@
112113
"outputs": [],
113114
"source": [
114115
"# Load the jobs DataFrame from DuckDB\n",
115-
"preprocessed_jobs_df = ea.load_preprocessed_jobs_dataframe_from_duckdb(\n",
116+
"preprocessed_jobs_df = load_and_preprocess_jobs(\n",
116117
" db_path=\"../data/slurm_data.db\",\n",
117118
" table_name=\"Jobs\",\n",
118119
")\n",
@@ -608,7 +609,11 @@
608609
]
609610
}
610611
],
611-
"metadata": {},
612+
"metadata": {
613+
"language_info": {
614+
"name": "python"
615+
}
616+
},
612617
"nbformat": 4,
613618
"nbformat_minor": 5
614619
}

0 commit comments

Comments
 (0)