Skip to content

Fixed character movement stuck bug #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed character movement stuck bug #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion UOP1_Project/Assets/Scripts/Characters/Protagonist.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class Protagonist : MonoBehaviour

private Vector2 _inputVector;
private float _previousSpeed;
private double _lastHitTime = double.NegativeInfinity;

//These fields are read and manipulated by the StateMachine actions
[NonSerialized] public bool jumpInput;
Expand All @@ -30,7 +31,29 @@ public class Protagonist : MonoBehaviour

private void OnControllerColliderHit(ControllerColliderHit hit)
{
lastHit = hit;
bool isHitAccepted = false;
double time = Time.timeAsDouble;
if (_lastHitTime < time)
{
// New hit is in new frame, discard our outdated hit
isHitAccepted = true;
}
else
{
// Its the same frame, let's decide which hit to keep
if (lastHit.normal.y < hit.normal.y)
{
// New hit is pointing more upwards, more likely a floor hit
// We should prioritize floor hits over wall hits
isHitAccepted = true;
}
}

if(isHitAccepted)
{
lastHit = hit;
_lastHitTime = time;
}
}

//Adds listeners for events being triggered in the InputReader script
Expand Down