Update URL check

* Make sure the real_time doc string is picked up by the URL check
* Do not check already checked links in url_check
  This should greatly speed up things

Author: urfeex

.github/helpers/check_urls.sh

@@ -38,6 +38,7 @@ urls=$(grep -oP '(http|ftp|https):\/\/([a-zA-Z0-9_-]+(?:(?:\.[a-zA-Z0-9_-]+)+))(
 fail_counter=0
 
 FAILED_LINKS=()
+CHECKED_LINKS=()
 for item in $urls; do
 #     echo $item
     skip=0
@@ -53,15 +54,18 @@ for item in $urls; do
     filename=$(echo "$item" | cut -d':' -f1)
     url=$(echo "$item" | cut -d':' -f2-)
     echo -n "Checking $url from file $filename"
-    if ! curl --head --silent --fail "$url" 2>&1 > /dev/null; then
-        echo -e " \033[0;31mNOT FOUND\033[32m\n"
+    if [[ $(echo ${CHECKED_LINKS[@]} | fgrep -w $url) ]]; then
+      echo -e " \033[36malready checked\033[0m"
+    elif ! curl --head --silent --fail "$url" 2>&1 > /dev/null; then
+        echo -e " \033[0;31mNOT FOUND\033[0m"
         FAILED_LINKS+=("$url from file $filename")
         ((fail_counter=fail_counter+1))
     else
-        printf " \033[32mok\033[0m\n"
+        echo -e " \033[32mok\033[0m"
     fi
+    CHECKED_LINKS+=("$url")
 done
 
 echo "Failed files:"
 printf '%s\n' "${FAILED_LINKS[@]}"
-exit $fail_counter
+exit $fail_counter

src/helpers.cpp

@@ -33,8 +33,11 @@
 #include <fstream>
 #include <iostream>
 
-const std::string RT_DOC_URL = "https://docs.universal-robots.com/Universal_Robots_ROS_Documentation/doc/"
-                               "ur_client_library/doc/real_time.html";
+// clang-format off
+// We want to keep the URL in one line to avoid formatting issues. This will make it easier to
+// extract the URL for an automatic check.
+const std::string RT_DOC_URL = "https://docs.universal-robots.com/Universal_Robots_ROS_Documentation/doc/ur_client_library/doc/real_time.html";
+// clang-format on
 
 namespace urcl
 {