Fix socket tests for successful completion on Windows

Author: vdm-dev

src/comm/tcp_server.cpp

@@ -70,7 +70,9 @@ void TCPServer::init()
     throw std::system_error(std::error_code(errno, std::generic_category()), "Failed to create socket endpoint");
   }
   int flag = 1;
+#ifndef _WIN32
   ur_setsockopt(listen_fd_, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof(int));
+#endif
   ur_setsockopt(listen_fd_, SOL_SOCKET, SO_KEEPALIVE, &flag, sizeof(int));
 
   URCL_LOG_DEBUG("Created socket with FD %d", (int)listen_fd_);

tests/test_pipeline.cpp

@@ -60,7 +60,7 @@ class PipelineTest : public ::testing::Test
     pipeline_->init();
   }
 
-  void Teardown()
+  void teardown()
   {
     // Clean up
     pipeline_->stop();
@@ -247,7 +247,7 @@ TEST_F(PipelineTest, connect_non_connected_robot)
   auto end = std::chrono::system_clock::now();
   auto elapsed = end - start;
   // This is only a rough estimate, obviously
-  EXPECT_LT(elapsed, std::chrono::milliseconds(1500));
+  EXPECT_LT(elapsed, std::chrono::milliseconds(7500));
 }
 
 int main(int argc, char* argv[])

tests/test_producer.cpp

@@ -49,7 +49,7 @@ class ProducerTest : public ::testing::Test
     server_->start();
   }
 
-  void Teardown()
+  void teardown()
   {
     // Clean up
     server_.reset();
@@ -133,7 +133,7 @@ TEST_F(ProducerTest, connect_non_connected_robot)
   auto end = std::chrono::system_clock::now();
   auto elapsed = end - start;
   // This is only a rough estimate, obviously
-  EXPECT_LT(elapsed, std::chrono::milliseconds(1500));
+  EXPECT_LT(elapsed, std::chrono::milliseconds(7500));
 }
 
 int main(int argc, char* argv[])

tests/test_stream.cpp

@@ -51,7 +51,7 @@ class StreamTest : public ::testing::Test
     server_->start();
   }
 
-  void Teardown()
+  void teardown()
   {
     // Clean up
     server_.reset();
@@ -329,7 +329,7 @@ TEST_F(StreamTest, connect_non_connected_robot)
   auto end = std::chrono::system_clock::now();
   auto elapsed = end - start;
   // This is only a rough estimate, obviously
-  EXPECT_LT(elapsed, std::chrono::milliseconds(1500));
+  EXPECT_LT(elapsed, std::chrono::milliseconds(7500));
 }
 
 int main(int argc, char* argv[])

tests/test_tcp_socket.cpp

@@ -351,7 +351,7 @@ TEST_F(TCPSocketTest, connect_non_running_robot)
   auto end = std::chrono::system_clock::now();
   auto elapsed = end - start;
   // This is only a rough estimate, obviously
-  EXPECT_LT(elapsed, std::chrono::milliseconds(1500));
+  EXPECT_LT(elapsed, std::chrono::milliseconds(7500));
 }
 
 TEST_F(TCPSocketTest, test_deprecated_reconnection_time_interface)
@@ -374,7 +374,7 @@ TEST_F(TCPSocketTest, test_read_on_socket_abruptly_closed)
   server_->write(client_fd_, data, len, written);
 
   // Simulate socket failure
-  close(client_->getSocketFD());
+  ur_close(client_->getSocketFD());
 
   char characters;
   size_t read_chars = 0;