Skip to content

Commit 33adccb

Browse files
committed
Add test for VersionInformation::toString()
1 parent de3e099 commit 33adccb

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/ur/version_information.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ VersionInformation VersionInformation::fromString(const std::string& str)
8686
}
8787
std::string VersionInformation::toString() const
8888
{
89-
return std::to_string(this->major) + "." + std::to_string(this->minor) + "." + std::to_string(this->bugfix) + "-" +
89+
return std::to_string(this->major) + "." + std::to_string(this->minor) + "." + std::to_string(this->bugfix) + "." +
9090
std::to_string(this->build);
9191
}
9292

tests/test_version_information.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,17 @@ TEST(version_information, test_is_e_series)
106106
EXPECT_FALSE(v2.isESeries());
107107
}
108108

109+
TEST(version_information, test_to_string)
110+
{
111+
std::string version_string = "5.5.0.1101319";
112+
auto v1 = VersionInformation::fromString(version_string);
113+
114+
EXPECT_EQ(v1.toString(), version_string);
115+
}
116+
109117
int main(int argc, char* argv[])
110118
{
111119
::testing::InitGoogleTest(&argc, argv);
112120

113121
return RUN_ALL_TESTS();
114-
}
122+
}

0 commit comments

Comments
 (0)