Skip to content

Commit 836aca5

Browse files
urfeexurmahp
andauthored
Apply suggestions from code review
Co-authored-by: Mads Holm Peters <[email protected]>
1 parent d1aa744 commit 836aca5

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

src/ur/dashboard_client.cpp

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ bool DashboardClient::commandPowerOff()
140140
{
141141
return commandPowerOffWithResponse().ok;
142142
}
143+
143144
DashboardResponse DashboardClient::commandPowerOffWithResponse()
144145
{
145146
return impl_->commandPowerOff();
@@ -149,6 +150,7 @@ bool DashboardClient::commandPowerOn(const std::chrono::duration<double> timeout
149150
{
150151
return commandPowerOnWithResponse(timeout).ok;
151152
}
153+
152154
DashboardResponse DashboardClient::commandPowerOnWithResponse(const std::chrono::duration<double> timeout)
153155
{
154156
return impl_->commandPowerOn(timeout);
@@ -158,6 +160,7 @@ bool DashboardClient::commandBrakeRelease()
158160
{
159161
return commandBrakeReleaseWithResponse().ok;
160162
}
163+
161164
DashboardResponse DashboardClient::commandBrakeReleaseWithResponse()
162165
{
163166
return impl_->commandBrakeRelease();
@@ -216,6 +219,7 @@ bool DashboardClient::commandStop()
216219
{
217220
return commandStopWithResponse().ok;
218221
}
222+
219223
DashboardResponse DashboardClient::commandStopWithResponse()
220224
{
221225
return impl_->commandStop();
@@ -245,6 +249,7 @@ bool DashboardClient::commandRestartSafety()
245249
{
246250
return commandRestartSafetyWithResponse().ok;
247251
}
252+
248253
DashboardResponse DashboardClient::commandRestartSafetyWithResponse()
249254
{
250255
return impl_->commandRestartSafety();
@@ -387,6 +392,7 @@ bool DashboardClient::commandRobotMode(std::string& robot_mode)
387392
}
388393
return response.ok;
389394
}
395+
390396
DashboardResponse DashboardClient::commandRobotModeWithResponse()
391397
{
392398
return impl_->commandRobotMode();
@@ -401,6 +407,7 @@ bool DashboardClient::commandGetLoadedProgram(std::string& loaded_program)
401407
}
402408
return response.ok;
403409
}
410+
404411
DashboardResponse DashboardClient::commandGetLoadedProgramWithResponse()
405412
{
406413
return impl_->commandGetLoadedProgram();
@@ -415,6 +422,7 @@ bool DashboardClient::commandSafetyMode(std::string& safety_mode)
415422
}
416423
return response.ok;
417424
}
425+
418426
DashboardResponse DashboardClient::commandSafetyModeWithResponse()
419427
{
420428
return impl_->commandSafetyMode();
@@ -429,6 +437,7 @@ bool DashboardClient::commandSafetyStatus(std::string& safety_status)
429437
}
430438
return response.ok;
431439
}
440+
432441
DashboardResponse DashboardClient::commandSafetyStatusWithResponse()
433442
{
434443
return impl_->commandSafetyStatus();
@@ -443,6 +452,7 @@ bool DashboardClient::commandProgramState(std::string& program_state)
443452
}
444453
return response.ok;
445454
}
455+
446456
DashboardResponse DashboardClient::commandProgramStateWithResponse()
447457
{
448458
return impl_->commandProgramState();
@@ -457,6 +467,7 @@ bool DashboardClient::commandGetOperationalMode(std::string& operational_mode)
457467
}
458468
return response.ok;
459469
}
470+
460471
DashboardResponse DashboardClient::commandGetOperationalModeWithResponse()
461472
{
462473
return impl_->commandGetOperationalMode();
@@ -466,6 +477,7 @@ bool DashboardClient::commandSetOperationalMode(const std::string& operational_m
466477
{
467478
return commandSetOperationalModeWithResponse(operational_mode).ok;
468479
}
480+
469481
DashboardResponse DashboardClient::commandSetOperationalModeWithResponse(const std::string& operational_mode)
470482
{
471483
return impl_->commandSetOperationalMode(operational_mode);
@@ -484,6 +496,7 @@ bool DashboardClient::commandSetUserRole(const std::string& user_role)
484496
{
485497
return commandSetUserRoleWithResponse(user_role).ok;
486498
}
499+
487500
DashboardResponse DashboardClient::commandSetUserRoleWithResponse(const std::string& user_role)
488501
{
489502
return impl_->commandSetUserRole(user_role);
@@ -498,6 +511,7 @@ bool DashboardClient::commandGetUserRole(std::string& user_role)
498511
}
499512
return response.ok;
500513
}
514+
501515
DashboardResponse DashboardClient::commandGetUserRoleWithResponse()
502516
{
503517
return impl_->commandGetUserRole();
@@ -507,6 +521,7 @@ bool DashboardClient::commandGenerateFlightReport(const std::string& report_type
507521
{
508522
return commandGenerateFlightReportWithResponse(report_type).ok;
509523
}
524+
510525
DashboardResponse DashboardClient::commandGenerateFlightReportWithResponse(const std::string& report_type)
511526
{
512527
return impl_->commandGenerateFlightReport(report_type);
@@ -516,6 +531,7 @@ bool DashboardClient::commandGenerateSupportFile(const std::string& dir_path)
516531
{
517532
return commandGenerateSupportFileWithResponse(dir_path).ok;
518533
}
534+
519535
DashboardResponse DashboardClient::commandGenerateSupportFileWithResponse(const std::string& dir_path)
520536
{
521537
return impl_->commandGenerateSupportFile(dir_path);
@@ -525,6 +541,7 @@ bool DashboardClient::commandSaveLog()
525541
{
526542
return commandSaveLogWithResponse().ok;
527543
}
544+
528545
DashboardResponse DashboardClient::commandSaveLogWithResponse()
529546
{
530547
return impl_->commandSaveLog();

0 commit comments

Comments
 (0)