Skip to content

Commit 98e1692

Browse files
committed
Add test for VersionInformation::toString()
1 parent e078a91 commit 98e1692

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/ur/version_information.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ VersionInformation VersionInformation::fromString(const std::string& str)
8686
}
8787
std::string VersionInformation::toString() const
8888
{
89-
return std::to_string(this->major) + "." + std::to_string(this->minor) + "." + std::to_string(this->bugfix) + "-" +
89+
return std::to_string(this->major) + "." + std::to_string(this->minor) + "." + std::to_string(this->bugfix) + "." +
9090
std::to_string(this->build);
9191
}
9292

tests/test_version_information.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,19 @@ TEST(version_information, test_relations)
8080
EXPECT_LT(v1, v3);
8181
EXPECT_LT(v4, v1);
8282
EXPECT_TRUE(v1 != v2);
83+
84+
TEST(version_information, test_to_string)
85+
{
86+
std::string version_string = "5.5.0.1101319";
87+
auto v1 = VersionInformation::fromString(version_string);
88+
89+
EXPECT_EQ(v1.toString(), version_string);
90+
}
8391
}
8492

8593
int main(int argc, char* argv[])
8694
{
8795
::testing::InitGoogleTest(&argc, argv);
8896

8997
return RUN_ALL_TESTS();
90-
}
98+
}

0 commit comments

Comments
 (0)