Catch Exception by reference and not by value (#130)

Felix Exner (fexner) · web-flow · commit f365f5a9a0a5 · 2022-11-21T08:45:40.000+01:00
In general this is a good idea and it will silence a compiler warning.
diff --git a/src/ur/dashboard_client.cpp b/src/ur/dashboard_client.cpp
@@ -62,7 +62,7 @@ bool DashboardClient::connect()
         ret_val = true;
       }
     }
-    catch (TimeoutException)
+    catch (const TimeoutException&)
     {
       URCL_LOG_WARN("Did not receive dashboard bootup message although connection was established. This should not "
                     "happen, please contact the package maintainers. Retrying anyway...");

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ bool DashboardClient::connect()`
`62`	`62`	`ret_val = true;`
`63`	`63`	`}`
`64`	`64`	`}`
`65`		`- catch (TimeoutException)`
	`65`	`+ catch (const TimeoutException&)`
`66`	`66`	`{`
`67`	`67`	`URCL_LOG_WARN("Did not receive dashboard bootup message although connection was established. This should not "`
`68`	`68`	`"happen, please contact the package maintainers. Retrying anyway...");`