Remove ament_* from format workflow and add them with ros-lit-action

Author: destogl

.github/workflows/ci-format.yml

@@ -16,15 +16,10 @@ jobs:
     name: Format
     runs-on: ubuntu-latest
     steps:
-    - uses: ros-tooling/[email protected]
-      with:
-        required-ros-distributions: foxy
     - uses: actions/checkout@v2
     - uses: actions/setup-python@v2
     - name: Install system hooks
       run: sudo apt-get install clang-format-10 cppcheck
-    - name: Source ROS2 environemnt to get access to ament_* hooks
-      run: source /opt/ros/foxy/setup.bash
-    - name: Check if there are ament hooks
-      run: ament_copyright
     - uses: pre-commit/[email protected]
+      with:
+        extra_args: --all-files --hook-stage manual

.github/workflows/ci-ros-lint.yml

@@ -0,0 +1,23 @@
+name: ROS2 Lint
+on:
+  pull_request:
+
+jobs:
+  ament_lint:
+    name: ament_${{ matrix.linter }}
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+          linter: [copyright, cppcheck, cpplint]
+    steps:
+    - uses: actions/checkout@v1
+    - uses: ros-tooling/[email protected]
+    - uses: ros-tooling/[email protected]
+      with:
+        distribution: foxy
+        linter: ${{ matrix.linter }}
+        package-name:
+          ros2_control_demo_hardware
+          ros2_control_demo_robot
+          ros2_control_demos

.pre-commit-config.yaml

@@ -29,6 +29,7 @@ repos:
       - id: end-of-file-fixer
       - id: mixed-line-ending
       - id: trailing-whitespace
+      - id: check-byte-order-marker  # Forbid UTF-8 byte-order markers
 
   # Python hooks
   - repo: https://github.com/asottile/pyupgrade
@@ -69,6 +70,7 @@ repos:
       - id: ament_cppcheck
         name: ament_cppcheck
         description: Static code analysis of C/C++ files.
+        stages: [commit]
         entry: ament_cppcheck
         language: system
         files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
@@ -79,6 +81,7 @@ repos:
       - id: ament_cpplint
         name: ament_cpplint
         description: Static code analysis of C/C++ files.
+        stages: [commit]
         entry: ament_cpplint
         language: system
         files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
@@ -100,6 +103,7 @@ repos:
       - id: ament_lint_cmake
         name: ament_lint_cmake
         description: Check format of CMakeLists.txt files.
+        stages: [commit]
         entry: ament_lint_cmake
         language: system
         files: CMakeLists.txt$
@@ -110,6 +114,7 @@ repos:
       - id: ament_copyright
         name: ament_copyright
         description: Check if copyright notice is available in all files.
+        stages: [commit]
         entry: ament_copyright
         language: system