Skip to content

Commit d5a1822

Browse files
author
Felix Exner
committed
Update formatting and config file comment
1 parent bf24ed4 commit d5a1822

File tree

3 files changed

+21
-9
lines changed

3 files changed

+21
-9
lines changed

ur_moveit_config/config/moveit_controllers.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ trajectory_execution:
55
allowed_execution_duration_scaling: 1.2
66
allowed_goal_duration_margin: 0.5
77
allowed_start_tolerance: 0.01
8-
execution_duration_monitoring: false # Not much use when using the scaled JTC
8+
execution_duration_monitoring: false # May lead to unexpectedly aborted goals with scaled JTC
99

1010
moveit_simple_controller_manager:
1111
controller_names:

ur_moveit_config/doc/index.rst

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,16 @@ Now you should be able to use the MoveIt Plugin in rviz2 to plan and execute tra
2525
robot as explained `here <https://moveit.picknik.ai/main/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html>`_.
2626

2727
.. note::
28-
The MoveIt configuration provided here has Trajectory Execution Monitoring *disabled*, as the Scaled Joint Trajectory Controller may cause trajectories to be executed at a lower velocity than they were originally planned by MoveIt. MoveIt's TEM however is not aware of this deliberate slow-down due to scaling and will in most cases unnecessarily (and unexpectedly) abort goals.
29-
30-
Until this incompatibility is resolved, the default value for `execution_duration_monitoring` is set to `false`. Users who wish to temporarily (re)enable TEM at runtime (for use with other, non-scaling controllers) can do so using the ROS 2 parameter services supported by MoveIt.
28+
The MoveIt configuration provided here has Trajectory Execution Monitoring (TEM) *disabled*, as the
29+
Scaled Joint Trajectory Controller may cause trajectories to be executed at a lower velocity
30+
than they were originally planned by MoveIt. MoveIt's TEM however is not aware of this
31+
deliberate slow-down due to scaling and will in most cases unnecessarily (and unexpectedly)
32+
abort goals.
33+
34+
Until this incompatibility is resolved, the default value for ``execution_duration_monitoring``
35+
is set to ``false``. Users who wish to temporarily (re)enable TEM at runtime (for use with
36+
other, non-scaling controllers) can do so using the ROS 2 parameter services supported by
37+
MoveIt.
3138

3239
.. literalinclude:: ../config/moveit_controllers.yaml
3340
:language: yaml

ur_robot_driver/doc/usage/move.rst

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,15 @@ Now you should be able to use the MoveIt Plugin in rviz2 to plan and execute tra
6868
robot as explained `here <https://moveit.picknik.ai/main/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html>`_.
6969

7070
.. note::
71-
Usually, MoveIt uses trajectory execution monitoring (TEM). If executing a trajectory takes too long,
72-
e.g. because the action server died or the robot is blocked, this will lead to an error in
73-
trajectory execution. However, this isn't necessarily compatible with the scaled joint
74-
trajectory controller (as long as TEM is not aware of the scaling), as execution time can
75-
be unbounded on purpose. Hence, TEM is disabled in the example MoveIt configuration.
71+
The MoveIt configuration provided here has Trajectory Execution Monitoring (TEM) *disabled*, as the
72+
Scaled Joint Trajectory Controller may cause trajectories to be executed at a lower velocity
73+
than they were originally planned by MoveIt. MoveIt's TEM however is not aware of this
74+
deliberate slow-down due to scaling and will in most cases unnecessarily (and unexpectedly)
75+
abort goals.
76+
77+
Until this incompatibility is resolved, the default value for ``execution_duration_monitoring``
78+
is set to ``false``. Users who wish to temporarily (re)enable TEM at runtime (for use with
79+
other, non-scaling controllers) can do so using the ROS 2 parameter services supported by
80+
MoveIt.
7681

7782
For more details, please see :ref:`ur_moveit_config`.

0 commit comments

Comments
 (0)