Fix: creating the dashboard client outside the try/catch block

Otherwise it will go out of scope afterwards and it will not be usable.

Author: urfeex

ur_robot_driver/src/dashboard_client_node.cpp

@@ -37,9 +37,10 @@
 
 #include "ur_robot_driver/dashboard_client_ros.hpp"
 
+#include <memory>
 #include <string>
 
-#include "rclcpp/rclcpp.hpp"
+#include <rclcpp/logging.hpp>
 #include "ur_robot_driver/urcl_log_handler.hpp"
 
 int main(int argc, char** argv)
@@ -53,13 +54,15 @@ int main(int argc, char** argv)
 
   ur_robot_driver::registerUrclLogHandler("");  // Set empty tf_prefix at the moment
 
+  std::shared_ptr<ur_robot_driver::DashboardClientROS> client;
   try {
-    ur_robot_driver::DashboardClientROS client(node, robot_ip);
+    client = std::make_shared<ur_robot_driver::DashboardClientROS>(node, robot_ip);
   } catch (const urcl::UrException& e) {
     RCLCPP_WARN(rclcpp::get_logger("Dashboard_Client"),
                 "%s This warning is expected on a PolyScopeX robot. If you don't want to see this warning, "
                 "please don't start the dashboard client. Exiting dashboard client now.",
                 e.what());
+    return 0;
   }
 
   rclcpp::spin(node);