Fix crashes on shutting down (backport #1270) #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not have the on_shutdown method implemented which gets called by the resource manager when shutting down. This could potentially result in crashes or pipeline overflows when shutting down the control node. There was an intermediate fix calling on_cleanup in the destructor, which isn't correct either. That got deleted. (cherry picked from commit 36b5c3d)
Member
|
This seems to work, but doesn't have the same effect, since ros-controls/ros2_control#2040 is needed. I'll wait for that and manually test with it before approving. |
Member
|
Upstream got merged. Re-running semi-binary builds and if their output looks good, I will merge this. |
urfeex
approved these changes
Feb 7, 2025
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
This makes shutdowns cleaner as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not have the on_shutdown method implemented which gets called by the resource manager when shutting down. This could potentially result in crashes or pipeline overflows when shutting down the control node.
There was an intermediate fix calling on_cleanup in the destructor, which isn't correct either. That got deleted.
This is an automatic backport of pull request #1270 done by Mergify.