Use sjtc and generate /clock topic #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinDp
approved these changes
Oct 14, 2024
Contributor
VinDp
left a comment
VinDp
left a comment
There was a problem hiding this comment.
Looks good and works as intended.
added 4 commits
October 15, 2024 11:30
Since we now use the scaled JTC we have to depend on ur_controllers and make sure the tests use the scaled JTC.
Author
|
Let's hold on that until the SJTC without required scaling interface is released and synced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With UniversalRobots/Universal_Robots_ROS2_Driver#1145 it is possible to use use the scaled JTC on systems that don't have the scaling state interface available. This way, we won't have to change the controller in the MoveIt configuration anymore in order to use the example MoveIt package with GZ Sim.
Draft until UniversalRobots/Universal_Robots_ROS2_Driver#1145 is merged.