Add SelectJobPlaceholder, job prefix and suffix#11
Closed
gaboss44 wants to merge 2 commits intoUniverseStudiosMC:clean-mainfrom
Closed
Add SelectJobPlaceholder, job prefix and suffix#11gaboss44 wants to merge 2 commits intoUniverseStudiosMC:clean-mainfrom
gaboss44 wants to merge 2 commits intoUniverseStudiosMC:clean-mainfrom
Conversation
- add a new placeholder that selects a job value from a player job list which can be sorted, filtered, and selected by position - add job prefix and suffix, for practicality (to separate colors, maybe job symbols, etc)
There was a problem hiding this comment.
👋 Hello @gaboss44, thank you for your first pull request!
We appreciate your contribution to UniverseJobs. A maintainer will review your changes soon.
Please make sure:
- Your code follows the project's coding style
- You've tested your changes
- The build passes (
mvn clean package)
Thanks for helping improve the plugin! 🚀
|
|
👋 This pull request has been automatically marked as stale because it has not had any activity in the last 30 days. It will be closed in 7 days if no further activity occurs. If you're still working on this:
|
|
🔒 This pull request has been automatically closed due to inactivity. Feel free to reopen it if you'd like to continue working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This introduces a new select-style placeholder that allows retrieving a specific job-related value from a player’s job list.
The placeholder supports filtering, multi-criteria sorting, and position-based selection, making it suitable for dynamic displays such as scoreboards, GUIs, and chat formats.
Also, job prefix and suffix values are exposed for convenience, for better formatting (e.g. colors, symbols, or separators).
The implementation does not modify existing placeholders.
Type of Change
Related Issues
This PR is not related to any known bug or issue
Checklist
Testing
I compiled the code using 'mvn package' and tried it locally (MC Paper version 1.21.10-117-ver/1.21.10@df4b668). The selector placeholder works as intended after testing its syntax. No errors show up in console when the placeholder is used, regardless of whether it finds a value.
Screenshots (if applicable)
There are no GUI changes in this PR