Skip to content

Comments

task(deps): Update to axum_server 0.8#1341

Merged
chriswk merged 5 commits intomainfrom
task/makeAxumServer08Compatible
Jan 15, 2026
Merged

task(deps): Update to axum_server 0.8#1341
chriswk merged 5 commits intomainfrom
task/makeAxumServer08Compatible

Conversation

@chriswk
Copy link
Member

@chriswk chriswk commented Dec 17, 2025

No description provided.

@chriswk chriswk self-assigned this Dec 17, 2025
Copilot AI review requested due to automatic review settings December 17, 2025 11:05
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ❌ 2 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.

View full job summary

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the axum-server dependency from version 0.7.3 to 0.8.0, which introduces breaking API changes requiring error handling updates. The Rust toolchain is also updated from 1.91.1 to 1.92.0 to support the new dependency version.

Key Changes:

  • Updated axum-server to 0.8.0 with explicit feature configuration (default-features = false)
  • Added error handling for from_tcp and from_tcp_rustls functions which now return Result types
  • Updated Rust toolchain to 1.92.0

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Updated axum-server to 0.8.0 with explicit feature selection and rust-version to 1.92.0
Cargo.lock Lockfile updates reflecting the new axum-server version and dependency changes
rust-toolchain.toml Updated Rust toolchain channel from 1.91.1 to 1.92.0
crates/oss/unleash-edge/src/main.rs Added error handling for axum-server API changes in server initialization code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 17, 2025 12:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 18, 2025 03:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@chriswk chriswk moved this from New to In Progress in Issues and PRs Dec 19, 2025
Copilot AI review requested due to automatic review settings December 19, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings December 22, 2025 03:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings January 13, 2026 16:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chriswk chriswk force-pushed the task/makeAxumServer08Compatible branch from b595377 to 6447d92 Compare January 15, 2026 12:40
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

@github-project-automation github-project-automation bot moved this from In Progress to Approved PRs in Issues and PRs Jan 15, 2026
Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge issues? apart from that should do the trick

Copilot AI review requested due to automatic review settings January 15, 2026 12:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/test-with-coverage.yaml:19

  • The RUST_VERSION environment variable is still set to 1.91.1, but the Rust toolchain has been updated to 1.92.0 in rust-toolchain.toml and Cargo.toml. This should be updated to 1.92.0 to maintain consistency and ensure the test workflow uses the correct Rust version.
  RUST_VERSION: 1.91.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chriswk chriswk merged commit bfa6b15 into main Jan 15, 2026
27 of 28 checks passed
@chriswk chriswk deleted the task/makeAxumServer08Compatible branch January 15, 2026 12:54
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Jan 15, 2026
@unleash-bot unleash-bot bot mentioned this pull request Jan 19, 2026
@unleash-bot unleash-bot bot mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants